Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlappingFieldsCanBeMergedRule: Fix performance degradation #3967

Merged
merged 2 commits into from Sep 10, 2023
Merged

OverlappingFieldsCanBeMergedRule: Fix performance degradation #3967

merged 2 commits into from Sep 10, 2023

Conversation

AaronMoat
Copy link
Contributor

Applies fixes from #3958 into 16.x.x, fewer changes as no stream support in 16.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Hi @AaronMoat, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@AaronMoat
Copy link
Contributor Author

@IvanGoncharov how closely do I need to pay attention to the codecov failure on this backport branch?

@IvanGoncharov
Copy link
Member

@IvanGoncharov how closely do I need to pay attention to the codecov failure on this backport branch?

@AaronMoat Sadly it breaks CI, but you can add a C8 comment to ignore those lines.

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Sep 6, 2023
@AaronMoat
Copy link
Contributor Author

Thanks @IvanGoncharov - added!

@IvanGoncharov IvanGoncharov merged commit 8f4c64e into graphql:16.x.x Sep 10, 2023
17 checks passed
@AaronMoat
Copy link
Contributor Author

AaronMoat commented Sep 11, 2023

Thanks @IvanGoncharov, appreciate all your help on this one! Is there a process to request a release for 16? As best I can tell this is manual not automated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants