Use Optional Chaining to globalThis.process.env.NODE_ENV
Retrieval
#4019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces optional chaining when accessing
globalThis.process.env.NODE_ENV
in the graphql-js codebase.The current implementation assumes that
globalThis.process.env
is always defined, which may not be the case in all environments. This assumption leads to a runtime error whenNODE_ENV
is accessed on an undefinedprocess.env
.By adding optional chaining (
?.
), we ensure thatNODE_ENV
is only accessed ifglobalThis.process
andprocess.env
are defined, thereby preventing potential runtime errors.This change improves the robustness of the code and makes it more compatible with various JavaScript environments.