incremental: use filtering instead of GraphQLResult #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
add-back-filtering
branch
3 times, most recently
from
3565b37
to
7fb50bd
Compare
|
use-undefined-for-empty corresponds to #4046 the above stats show that with filtering, we have significant performance boost for synchronous lists, and we have maintained parity even for asynchronous lists |
yaacovCR
changed the title
yaacovCR
force-pushed
the
add-back-filtering
branch
from
7fb50bd
to
5c427d1
Compare
yaacovCR
force-pushed
the
add-back-filtering
branch
from
5c427d1
to
1633e92
Compare
introducing separate looping functions for when streamUsage is defined
yaacovCR
force-pushed
the
add-back-filtering
branch
from
1633e92
to
e5c9a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that filtering has been removed from #4026, this draft PR could be checked out to see what it would look like to reintroduce it.