Add build script #274
Add build script #274
Conversation
| @@ -13,8 +13,7 @@ | |||
| ], | |||
| "env": { | |||
| "cjs": { | |||
| "presets": [["@babel/preset-env", { "modules": "commonjs" }]], | |||
| "plugins": ["./resources/inline-invariant"] | |||
There was a problem hiding this comment.
This plugin doesn't exist. Since the babel config wasn't used by the build script, it wasn't erroring out.
| @@ -11,15 +11,7 @@ | |||
| "type": "git", | |||
| "url": "http://github.com/graphql/graphql-relay-js.git" | |||
| }, | |||
| "main": "lib/index.js", | |||
| "directories": { | |||
There was a problem hiding this comment.
directories and files are no longer needed since we'll be publishing directly from the dist directory
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 19 19
Lines 595 595
Branches 38 38
=======================================
Hits 592 592
Misses 3 3 Continue to review full report at Codecov.
|
| @@ -478,4 +478,21 @@ overrides: | |||
| no-console: off | |||
| - files: '**/__*__/**' | |||
| rules: | |||
| node/no-unpublished-import: off | |||
There was a problem hiding this comment.
Needed to add this since there were linting issues with the existing test files
There was a problem hiding this comment.
just add FIXME if it something we can fix in future
There was a problem hiding this comment.
This is something we had added in the other repos as an override for test files. And it makes sense to turn it off in that context but not for other files.
| return packageJSON; | ||
| } | ||
|
|
||
| function showStats() { |
There was a problem hiding this comment.
can you sync up both this and express-graphql repo in a separate PR so this function will move into utils.js.
This aligns the build process with the one currently used by
express-graphql