Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run prettier on generated output #343

Merged
merged 3 commits into from Jun 22, 2021

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Jun 22, 2021

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #343 (0265e33) into main (a6596ae) will not change coverage.
The diff coverage is n/a.

❗ Current head 0265e33 differs from pull request most recent head 28d1c14. Consider uploading reports for the commit 28d1c14 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #343   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          633       633           
  Branches        37        37           
=========================================
  Hits           633       633           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6596ae...28d1c14. Read the comment docs.

@saihaj
Copy link
Member Author

saihaj commented Jun 22, 2021

@IvanGoncharov We don't even publish this as a branch on GitHub so wouldn't make much difference if we prettify output?

@@ -6999,6 +6999,7 @@
"version": "3.4.0",
"resolved": "https://registry.npmjs.org/uuid/-/uuid-3.4.0.tgz",
"integrity": "sha512-HjSDRw6gZE5JMggctHBcjVak08+KEVhSIiDzFnT9S9aegmp85S/bReBVTb4QTFaRNptJ9kuYaNhnbNEOkbKb/A==",
"deprecated": "Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical.
But in the future, can you please checklist of changed files to see unrelated files?

@IvanGoncharov IvanGoncharov merged commit 14753dd into graphql:main Jun 22, 2021
@saihaj saihaj deleted the build-prettier branch June 22, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants