Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeDefinitions: Allow to pass number as ID values #344

Merged
merged 1 commit into from Jun 22, 2021

Conversation

IvanGoncharov
Copy link
Member

Fixes #219
Fixes #218

@IvanGoncharov IvanGoncharov added the PR: feature 🚀 requires increase of "minor" version number label Jun 22, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #344 (735164f) into main (14753dd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #344   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          633       633           
  Branches        37        37           
=========================================
  Hits           633       633           
Impacted Files Coverage Δ
src/node/node.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14753dd...735164f. Read the comment docs.

@IvanGoncharov IvanGoncharov merged commit 8c0535e into graphql:main Jun 22, 2021
@IvanGoncharov IvanGoncharov deleted the pr_branch branch June 22, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toGlobalId expects ID as a string
1 participant