fix: Connection config nodetype #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 745 745
Branches 51 51
=========================================
Hits 745 745
Continue to review full report at Codecov.
|
saihaj
force-pushed
the
fix-connection-type
branch
from
b9dc4df
to
7f34d22
Compare
renatobenks
approved these changes
Aug 1, 2021
| @@ -75,7 +75,7 @@ export type ConnectionArguments = { | |||
|
|
|||
| type ConnectionConfig = { | |||
| name?: string, | |||
| nodeType: GraphQLNamedType | GraphQLNonNull<GraphQLNamedType>, | |||
| nodeType: GraphQLOutputType, | |||
There was a problem hiding this comment.
@saihaj Output types include arrays :( so we can't use it
How about you add GraphQLInputNamedType and GraphQLOutputNamedType to graphql-js?
There was a problem hiding this comment.
This was merged and released to 16.x.x alpha channel graphql/graphql-js#3063 as we discussed on Slack I will update to use alpha for main and then I can rebase this branch
IvanGoncharov
added a commit
to IvanGoncharov/graphql-relay-js
that referenced
this pull request
Dec 7, 2021
IvanGoncharov
added a commit
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug in TypeScript Migration #340 a6d412e