Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use object freeze for connection args #353

Merged
merged 1 commit into from Aug 16, 2021

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Aug 1, 2021

TypeScript Migration #340 we are cleaning up these types 49746d6 so getting this change here.

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #353 (2f49665) into main (1723186) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          745       745           
  Branches        51        51           
=========================================
  Hits           745       745           
Impacted Files Coverage Δ
src/connection/connection.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1723186...2f49665. Read the comment docs.

@IvanGoncharov IvanGoncharov added the PR: feature 🚀 requires increase of "minor" version number label Aug 16, 2021
@IvanGoncharov IvanGoncharov merged commit 39ecad2 into graphql:main Aug 16, 2021
@saihaj saihaj deleted the freeze branch August 16, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants