Fix: 'fromGlobalId' trowing on invalide UTF code points #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: bug fix 🐞
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 737 744 +7
Branches 47 48 +1
=========================================
+ Hits 737 744 +7
Continue to review full report at Codecov.
|
Fixes graphql#358 Note: it's temprorary workaround until we design a better API
IvanGoncharov
force-pushed
the
pr_branch
branch
from
1b72dfb
to
dc5e1dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #358
Note: it's temprorary workaround until we design a better API