Skip to content

Commit

Permalink
Extend __typename at subscription root RFC discussion (#669)
Browse files Browse the repository at this point in the history
  • Loading branch information
benjie committed Apr 25, 2021
1 parent 389d6c4 commit f0461a5
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions agendas/2021-05-06.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ Example agenda item:
- Status Update
- Fields vs Input Objects
1. [Glossary RFC](https://github.com/graphql/graphql-spec/pull/846) (15m, Benjie)
1. [Advancing `__typename` not valid at subscription root RFC](https://github.com/graphql/graphql-spec/pull/776) (5m, Benjie)
- Ivan has approved [the GraphQL.js changes](https://github.com/graphql/graphql-js/pull/2861)
- Main question: have other implementors had a chance to look at this yet?
1. [Advancing `__typename` not valid at subscription root RFC](https://github.com/graphql/graphql-spec/pull/776) (30m, Benjie)
- Ivan approved [the GraphQL.js changes](https://github.com/graphql/graphql-js/pull/2861)
- Have since updated the implementation to more closely mirror the spec.
- Potential validation oversight - @skip/@include; see related RFC: https://github.com/graphql/graphql-spec/pull/860
- Question: have other implementors had a chance to look at this yet?
1. *ADD YOUR AGENDA ABOVE*

0 comments on commit f0461a5

Please sign in to comment.