Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend __typename at subscription root RFC discussion #669

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Extend __typename at subscription root RFC discussion #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions agendas/2021-05-06.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ Example agenda item:
- Status Update
- Fields vs Input Objects
1. [Glossary RFC](https://github.com/graphql/graphql-spec/pull/846) (15m, Benjie)
1. [Advancing `__typename` not valid at subscription root RFC](https://github.com/graphql/graphql-spec/pull/776) (5m, Benjie)
- Ivan has approved [the GraphQL.js changes](https://github.com/graphql/graphql-js/pull/2861)
- Main question: have other implementors had a chance to look at this yet?
1. [Advancing `__typename` not valid at subscription root RFC](https://github.com/graphql/graphql-spec/pull/776) (30m, Benjie)
- Ivan approved [the GraphQL.js changes](https://github.com/graphql/graphql-js/pull/2861)
- Have since updated the implementation to more closely mirror the spec.
- Potential validation oversight - @skip/@include; see related RFC: https://github.com/graphql/graphql-spec/pull/860
- Question: have other implementors had a chance to look at this yet?
1. *ADD YOUR AGENDA ABOVE*