Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value coercion to Jan 2022 WG #843

Merged
merged 1 commit into from Jan 6, 2022

Conversation

benjie
Copy link
Member

@benjie benjie commented Jan 6, 2022

Default value coercion is currently stage 2.

To advance to stage 3 we need:

  1. Consensus the solution is complete (via editor or working group)
  2. Complete spec edits, including examples and prose
  3. Compliant implementation in GraphQL.js (fully tested and merged or ready to merge)

I believe conditions 1 and 3 are satisfied - Lee stated in September:

@graphql/implementers please take one last look at this stack of changes. I'm planning to clean this up and land soon, I'm pretty confident this is the right change. One last chance to give a compelling reason why not.
-- graphql/graphql-js#3049 (comment)

I've just rewritten the algorithm in the spec to match Lee's implementation in GraphQL.js, so I believe this may be ready to go also (pending review).

@benjie benjie merged commit 2f2eb19 into main Jan 6, 2022
@benjie benjie deleted the wg-202201-default-value-coercion branch January 6, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant