Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump helm/kind-action from 1.9.0 to 1.10.0 in /.github/workflows #41016

Closed
wants to merge 1 commit into from
Closed

Bump helm/kind-action from 1.9.0 to 1.10.0 in /.github/workflows #41016

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2024 •
edited

Bumps helm/kind-action from 1.9.0 to 1.10.0.

Release notes

Sourced from helm/kind-action's releases.

v1.10.0

Requirements

We changed to use wget instead of curl

What's Changed

Full Changelog: helm/kind-action@v1.9.0...v1.10.0

Commits
  • 0025e74 Bump actions/checkout from 4.1.2 to 4.1.3 in the actions group (#109)
  • 2a7d25f bump kind to 0.22.0 / kubectl and general housekeeping (#107)
  • d821386 Bump actions/checkout from 4.1.2 to 4.1.3 (#108)
  • e89fbc4 Bump actions/checkout from 4.1.1 to 4.1.2 (#106)
  • 8300bd0 Update kind to release v0.21.0 (#104)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github-actions no-changelog Indicates that a PR does not require a changelog entry labels Apr 29, 2024
@dependabot
Bump helm/kind-action from 1.9.0 to 1.10.0 in /.github/workflows
ac40e5e 
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/helm/kind-action/releases)
- [Commits](helm/kind-action@99576bf...0025e74)

---
updated-dependencies:
- dependency-name: helm/kind-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/dot-github/workflows/helm/kind-action-1.10.0 branch from aec4ce1 to ac40e5e Compare April 29, 2024 17:37
@codingllama
Copy link
Contributor

Friendly ping GHA reviewers?

@codingllama codingllama added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@codingllama codingllama added this pull request to the merge queue May 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 9, 2024
@codingllama codingllama added this pull request to the merge queue May 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 9, 2024
@codingllama
Copy link
Contributor

codingllama commented May 9, 2024 •
edited

It looks like this did break CI: https://github.com/gravitational/teleport/actions/runs/9018315102/job/24778663739.

Create KinD cluster:

/__w/_actions/helm/kind-action/0025e74a8c7512023d06dc019c617aa3cf561fde/kind.sh: line 193: wget: command not found

Post Create KinD cluster:

/__w/_actions/helm/kind-action/0025e74a8c7512023d06dc019c617aa3cf561fde/cleanup.sh: line 32: kind: command not found

Note that "post create" is doomed if "create" fails. Not sure if that's something we can fix.

Also is it supposed to be written "KinD"?

@tigrato, could you take a look please? Feel free to close the PR if we don't care about this upgrade.

@codingllama codingllama requested a review from tigrato May 9, 2024 14:07
@tigrato
Copy link
Contributor

tigrato commented May 9, 2024 •
edited

@tigrato, could you take a look please? Feel free to close the PR if we don't care about this upgrade.

This PR https://github.com/helm/kind-action/pull/107/files replaced curl with wget and our runner don't have it available.
I will add a PR to add wget to buildbox

Wait, they are reverting it again to curl helm/kind-action#110 maybe we can wait until the PR is merged and a new release is cut

@codingllama
Copy link
Contributor

Wait, they are reverting it again to curl helm/kind-action#110

Close this and wait for the next kind-action release, then?

@tigrato
Copy link
Contributor

tigrato commented May 9, 2024

Wait, they are reverting it again to curl helm/kind-action#110

Close this and wait for the next kind-action release, then?

yep. Hopping they release it soon

@tigrato tigrato closed this May 9, 2024
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github May 9, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/dot-github/workflows/helm/kind-action-1.10.0 branch May 9, 2024 14:20
@codingllama
Copy link
Contributor

Thanks for looking it up, Tiago!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas klizhentas is a code owner

@russjones russjones Awaiting requested review from russjones russjones is a code owner

@r0mant r0mant Awaiting requested review from r0mant r0mant is a code owner

@zmb3 zmb3 Awaiting requested review from zmb3 zmb3 is a code owner

@fheinecke fheinecke Awaiting requested review from fheinecke fheinecke is a code owner

@camscale camscale Awaiting requested review from camscale camscale is a code owner

@tcsc tcsc Awaiting requested review from tcsc tcsc is a code owner

@tigrato tigrato Awaiting requested review from tigrato

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file github-actions no-changelog Indicates that a PR does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codingllama @tigrato @rosstimothy