Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v15] Add authentication method status indicators to the account settings page #41169

Merged
merged 3 commits into from
May 6, 2024
Merged

[v15] Add authentication method status indicators to the account settings page #41169

merged 3 commits into from
May 6, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented May 2, 2024

Backport #40904 to branch/v15

changelog: Added indicators on the account settings page that tell which authentication methods are active.

@github-actions github-actions bot requested review from ravicious and zmb3 May 2, 2024 20:29
@bl-nero bl-nero enabled auto-merge May 6, 2024 11:15
@bl-nero
Copy link
Contributor Author

bl-nero commented May 6, 2024

Retested manually:

  • Setting and changing password (OSS)
  • Displaying accounts page:
    • Legacy user (password state unknown) (OSS)
    • MFA off, passkeys defined in account settings (OSS)
    • MFA off, MFAs defined in account settings (OSS)
    • MFA optional, passwordless allowed, but no passkeys or MFA defined (OSS)
    • MFA optional, passwordless allowed, both passkeys and MFAs defined (OSS, Enterprise)

@bl-nero bl-nero added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@bl-nero bl-nero added this pull request to the merge queue May 6, 2024
Merged via the queue into branch/v15 with commit 8ec03f3 May 6, 2024
40 checks passed
@bl-nero bl-nero deleted the bot/backport-40904-branch/v15 branch May 6, 2024 20:17
@josh-ferrell josh-ferrell mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravicious ravicious ravicious approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees
No one assigned
Labels
backport size/md ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bl-nero @ravicious @zmb3