Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some Tabs component uses #41489

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented May 13, 2024

See #35870

Using Tabs components within a TabItem results in a poor user experience. This chagne removes some instances of this pattern:

  • WebAuthn guide
  • MongoDB Atlas guide
  • Installation page: Remove Homebrew instructions in favor of a Notice advising against using Homebrew.
  • Uninstall Teleport guide
  • Access Controls Getting Started

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

🤖 Vercel preview here: https://docs-izjis1beg-goteleport.vercel.app/docs/ver/preview

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@ptgott ptgott added the no-changelog Indicates that a PR does not require a changelog entry label May 15, 2024
Copy link

🤖 Vercel preview here: https://docs-3ig7vund9-goteleport.vercel.app/docs/ver/preview

See #35870

Using `Tabs` components within a `TabItem` results in a poor user
experience. This chagne removes some instances of this pattern:

- WebAuthn guide
- MongoDB Atlas guide
- Installation page: Remove Homebrew instructions in favor of a Notice
  advising against using Homebrew.
- Uninstall Teleport guide
- Access Controls Getting Started
@ptgott ptgott force-pushed the paul.gottschling/35870-tabs branch from 0f443a6 to f992d95 Compare May 16, 2024 15:40
@ptgott ptgott added this pull request to the merge queue May 16, 2024
Copy link

🤖 Vercel preview here: https://docs-66vrnvfny-goteleport.vercel.app/docs/ver/preview

Merged via the queue into master with commit 8587249 May 16, 2024
38 checks passed
@ptgott ptgott deleted the paul.gottschling/35870-tabs branch May 16, 2024 15:56
@public-teleport-github-review-bot

@ptgott See the table below for backport results.

Branch Result
branch/v15 Failed

ptgott added a commit that referenced this pull request May 16, 2024
Backports #41489

See #35870

Using `Tabs` components within a `TabItem` results in a poor user
experience. This chagne removes some instances of this pattern:

- WebAuthn guide
- MongoDB Atlas guide
- Installation page: Remove Homebrew instructions in favor of a Notice
  advising against using Homebrew.
- Uninstall Teleport guide
- Access Controls Getting Started
justinas pushed a commit that referenced this pull request May 20, 2024
See #35870

Using `Tabs` components within a `TabItem` results in a poor user
experience. This chagne removes some instances of this pattern:

- WebAuthn guide
- MongoDB Atlas guide
- Installation page: Remove Homebrew instructions in favor of a Notice
  advising against using Homebrew.
- Uninstall Teleport guide
- Access Controls Getting Started
ptgott added a commit that referenced this pull request May 22, 2024
Backports #41489

See #35870

Using `Tabs` components within a `TabItem` results in a poor user
experience. This chagne removes some instances of this pattern:

- WebAuthn guide
- MongoDB Atlas guide
- Installation page: Remove Homebrew instructions in favor of a Notice
  advising against using Homebrew.
- Uninstall Teleport guide
- Access Controls Getting Started
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
Backports #41489

See #35870

Using `Tabs` components within a `TabItem` results in a poor user
experience. This chagne removes some instances of this pattern:

- WebAuthn guide
- MongoDB Atlas guide
- Installation page: Remove Homebrew instructions in favor of a Notice
  advising against using Homebrew.
- Uninstall Teleport guide
- Access Controls Getting Started
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants