Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tctl: add PKI domain flag for tctl auth sign --format=windows #41495

Merged
merged 1 commit into from
May 14, 2024
Merged

tctl: add PKI domain flag for tctl auth sign --format=windows #41495

merged 1 commit into from
May 14, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented May 13, 2024

This comes in handy for troubleshooting multi-domain setups.

@zmb3 zmb3 added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels May 13, 2024
@github-actions github-actions bot added desktop-access size/sm tctl tctl - Teleport admin tool labels May 13, 2024
probakowski
probakowski reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using cmp.Or means it will be pretty cumbersome to backport, right?

@zmb3
Copy link
Collaborator Author

zmb3 commented May 13, 2024 •
edited

Using cmp.Or means it will be pretty cumbersome to backport, right?

For now, yeah, it can only Go to v15. That's okay though, as:

  1. this is a debugging tool and not required functionality
  2. Go 1.21 will go out of support soon at which point we'll have to update branch/v14 to a newer version of Go anyway and can backport this if we decide to.

Edit: I was mistaken, v15 is still on Go 1.21. I will change this (for now - I love cmp.Or!!)

@zmb3
tctl: add PKI domain flag for tctl auth sign --format=windows
43807c0 
This comes in handy for troubleshooting multi-domain setups.
@zmb3 zmb3 force-pushed the zmb3/tctl-win-pki-domain branch from 984476e to 43807c0 Compare May 14, 2024 15:48
@zmb3 zmb3 enabled auto-merge May 14, 2024 19:47
@zmb3 zmb3 added this pull request to the merge queue May 14, 2024
Merged via the queue into master with commit 5a10566 May 14, 2024
38 checks passed
@zmb3 zmb3 deleted the zmb3/tctl-win-pki-domain branch May 14, 2024 20:25
@public-teleport-github-review-bot
Copy link

@zmb3 See the table below for backport results.

Branch Result
branch/v13 Create PR
branch/v14 Create PR
branch/v15 Create PR

This was referenced May 14, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probakowski probakowski probakowski approved these changes

@ibeckermayer ibeckermayer ibeckermayer approved these changes

Assignees
No one assigned
Labels
backport/branch/v13 backport/branch/v14 backport/branch/v15 desktop-access no-changelog Indicates that a PR does not require a changelog entry size/sm tctl tctl - Teleport admin tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmb3 @probakowski @ibeckermayer