test for auto user deactivation audit event #41497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* expect deactivation audit event
GavinFrazar
added
database-access
greedy52
approved these changes
May 14, 2024
ravicious
approved these changes
May 15, 2024
|
@GavinFrazar See the table below for backport results.
|
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates test cases for database auto user provisioning to ensure that deactivation audit events are being sent.
In my PR that added support for spanner I noticed and fixed an issue where our mock mysql db sends a response that causes a panic right before the mysql user deactivation audit event is emitted.
We have a deferred
recover()in our db server, so it didn't cause a test failure but it did silently prevent the audit event.That panic is probably not realistically going to happen, but I guarded against it anyway.
I didn't extract that extra guard in the mysql code from the spanner PR before merging, so here's this PR which I will backport to v14 along with the mysql panic fix.
I ensured that these test updates fail without the mysql fix.