Fan out events in async mode for async recordings. #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
requested review from
a-palchikov,
fspmarshall,
r0mant and
webvictim
as code owners
|
@russjones this is a forward port of 4.4 issue |
klizhentas
force-pushed
the
sasha/fwd-async
branch
from
888afe8
to
2341d64
Compare
a-palchikov
approved these changes
Nov 13, 2020
| } | ||
| elapsedTime := time.Since(start) | ||
| log.Debugf("Emitted all events in %v.", elapsedTime) | ||
| require.True(t, elapsedTime < time.Second) |
There was a problem hiding this comment.
This might be problematic in CI context and super sensitive to workloads existing in parallel. I'd leave it as a warning and a log entry if that's longer than the specified threshold but not enforce it.
There was a problem hiding this comment.
I think we will miss the warning if we don't enforce the threshold. You are right that this is not the best practice. I will think about improveing it.
|
Here are details and a goroutine dump from a different machine (running a 5.0.0 beta) which I just discovered also has the hanging problem - just in case there's anything different for the forward port: |
|
To me it looks like the auditwriter's which blocks further processing of events. The only way it could get there is by ignoring to |
russjones
approved these changes
Nov 13, 2020
|
@a-palchikov you have a great eye for edge cases :) The PR has this edge case covered, so this hang should disappear. |
klizhentas
force-pushed
the
sasha/fwd-async
branch
from
2341d64
to
7b9a4c7
Compare
This commit fixes #4695. Teleport in async recording mode sends all events to disk, and uploads them to the server later. It uploads some events synchronously to the audit log so they show up in the global event log right away. However if the auth server is slow, the fanout blocks the session. This commit makes the fanout of some events to be fast, but nonblocking and never fail so sessions will not hang unless the disk writes hang. It adds a backoff period and timeout after which some events will be lost, but session will continue without locking.
klizhentas
force-pushed
the
sasha/fwd-async
branch
from
7b9a4c7
to
c336798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #4695.
Teleport in async recording mode sends all events to disk,
and uploads them to the server later.
It uploads some events synchronously to the audit log so
they show up in the global event log right away.
However if the auth server is slow, the fanout blocks the session.
This commit makes the fanout of some events to be fast,
but nonblocking and never fail so sessions will not hang
unless the disk writes hang.
It adds a backoff period and timeout after which some
events will be lost, but session will continue without locking.