This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Directory sharing menu item #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibeckermayer
changed the base branch from
isaiah/add-dir-sharing-to-acl
to
master
zmb3
approved these changes
Jul 5, 2022
hatched
reviewed
Jul 5, 2022
kimlisa
reviewed
Jul 5, 2022
Comment on lines
+107
to
+108
| font-weight: ${({ theme }) => theme.fontWeights.bold}; | ||
| font-size: ${({ theme }) => theme.fontSizes[6] + 'px'}; |
There was a problem hiding this comment.
i like this, we should be doing this more to keep in line with our theme @rudream
ibeckermayer
requested review from
kimlisa and
hatched
and removed request for
gzdunek
kimlisa
approved these changes
Jul 6, 2022
ibeckermayer
added a commit
that referenced
this pull request
Jul 19, 2022
ibeckermayer
added a commit
that referenced
this pull request
Jul 19, 2022
ibeckermayer
added a commit
that referenced
this pull request
Jul 20, 2022
ibeckermayer
added a commit
that referenced
this pull request
Jul 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new "Share Directory" item to the dropdown menu of a Desktop Session's top bar (when RBAC enabled)
Also refactors the top bar to push the (new) "directory sharing in progress", clipboard sharing enabled, and recording enabled icons to the right, next to the menu button ("...")
This is just the UI scaffolding, it's not meant to do anything yet except cause the UI to properly change according to internal state changes.
I also clean up the tdp client a bit in preparation for passing it a directory handle.
Requires backport to v9/v10