Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ui): notifications cypress ui tests #5901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test(ui): notifications cypress ui tests #5901

wants to merge 2 commits into from

Conversation

kkibbey1996
Copy link
Contributor

@kkibbey1996 kkibbey1996 commented Nov 20, 2023 •
edited by graviteeio

Issue

Authored by @RubenMMSantos (PR created by me in mean time while we get source control issues under control)

Description

End To End UI tests to cover API Notification Settings

Additional context

📚  View the storybook of this branch here

@kkibbey1996 kkibbey1996 requested a review from a team as a code owner November 20, 2023 15:46
@RubenMMSantos RubenMMSantos force-pushed the test/api-notifications-ui-tests-run-e2e branch from 23cbdc5 to a0f317a Compare November 20, 2023 15:54
@kkibbey1996 kkibbey1996 force-pushed the test/api-notifications-ui-tests-run-e2e branch from a0f317a to dd45835 Compare November 20, 2023 15:57
@RubenMMSantos RubenMMSantos force-pushed the test/api-notifications-ui-tests-run-e2e branch from dd45835 to 3ffdd3a Compare November 23, 2023 11:58
@cypress Cypress
Copy link

cypress bot commented Nov 23, 2023 •
edited

10 failed tests on run #510 ↗︎

10 70 0 0 Flakiness 0

Details:

test(ui): notifications cypress ui tests
Project: APIM UI Tests Commit: 0beaedbc1c
Status: Failed Duration: 07:48 💡
Started: Jan 19, 2024 10:42 AM Ended: Jan 19, 2024 10:50 AM
Failed  policy-studio/ui-ps-create-and-modify-flow.spec.ts • 4 failed tests

View Output Video

Test Artifacts
Create and modify a flow in Policy Studio > Verify that flows can be created and modified in Policy Studio > should create a common flow using the "+" icon Test Replay Screenshots Video
Create and modify a flow in Policy Studio > Verify that flows can be created and modified in Policy Studio > should show newly added header when calling Gateway Test Replay Screenshots Video
Create and modify a flow in Policy Studio > Verify that flows can be created and modified in Policy Studio > should edit flow details of a common flow using pen icon Test Replay Screenshots Video
Create and modify a flow in Policy Studio > Verify that flows can be created and modified in Policy Studio > should have header when calling Gateway with updated path Test Replay Screenshots Video
Failed  ui-api-info.spec.ts • 1 failed test

View Output Video

Test Artifacts
API Info Page functionality > Verify Info Page Elements Test Replay Screenshots Video
Failed  ui-api-notifications.spec.ts • 1 failed test

View Output Video

Test Artifacts
Notifications page > Edit notification > Edit notification, save changes and check notifications work Test Replay Screenshots Video
Failed  ui-api-plans.spec.ts • 4 failed tests

View Output Video

Test Artifacts
API Plans Feature > Create a generic New Plan (API Key), verify and delete Test Replay Screenshots Video
API Plans Feature > Create a generic New Plan (OAuth2), verify and delete Test Replay Screenshots Video
API Plans Feature > Create a generic New Plan (JWT), verify and delete Test Replay Screenshots Video
API Plans Feature > Create a generic New Plan (Keyless), verify and delete Test Replay Screenshots Video

Review all test suite changes for PR #5901 ↗︎

gaetanmaisse
gaetanmaisse approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@gaetanmaisse gaetanmaisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments

...pi/api-navigation/api-confirm-deployment-dialog/api-confirm-deployment-dialog.component.html Outdated Show resolved Hide resolved
gravitee-apim-console-webui/src/management/api/api-navigation/api-navigation.component.html Outdated Show resolved Hide resolved
gravitee-apim-e2e/ui-test/integration/apim/ui/apis/ui-api-notifications.spec.ts Outdated Show resolved Hide resolved
gravitee-apim-e2e/ui-test/integration/apim/ui/apis/ui-api-notifications.spec.ts Outdated Show resolved Hide resolved
ctschacher
ctschacher reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@ctschacher ctschacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, pretty good for a first PR 👍🏻
I just added some comments you might want to consider to improve the tests a bit.

gravitee-apim-e2e/ui-test/integration/apim/ui/apis/ui-api-notifications.spec.ts Outdated Show resolved Hide resolved
gravitee-apim-e2e/ui-test/integration/apim/ui/apis/ui-api-notifications.spec.ts Show resolved Hide resolved
gravitee-apim-e2e/ui-test/integration/apim/ui/apis/ui-api-notifications.spec.ts Show resolved Hide resolved
gravitee-apim-e2e/ui-test/integration/apim/ui/apis/ui-api-notifications.spec.ts Show resolved Hide resolved
@RubenMMSantos RubenMMSantos force-pushed the test/api-notifications-ui-tests-run-e2e branch 5 times, most recently from 54f72c2 to 4d11a87 Compare December 8, 2023 15:06
@RubenMMSantos RubenMMSantos force-pushed the test/api-notifications-ui-tests-run-e2e branch from 4d11a87 to 0407c81 Compare December 19, 2023 15:21
@gaetanmaisse gaetanmaisse force-pushed the test/api-notifications-ui-tests-run-e2e branch from 0407c81 to 69ac2f0 Compare December 22, 2023 13:49
@kkibbey1996 kkibbey1996 force-pushed the test/api-notifications-ui-tests-run-e2e branch from 69ac2f0 to 9547046 Compare January 19, 2024 10:12
@RubenMMSantos RubenMMSantos force-pushed the test/api-notifications-ui-tests-run-e2e branch from 9547046 to 0beaedb Compare January 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenMMSantos RubenMMSantos RubenMMSantos left review comments

@ctschacher ctschacher ctschacher left review comments

@jourdiw jourdiw jourdiw left review comments

@gaetanmaisse gaetanmaisse gaetanmaisse approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@RubenMMSantos RubenMMSantos

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@kkibbey1996 @gaetanmaisse @RubenMMSantos @ctschacher @jourdiw