fix: http redirection to https #6910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passionne
force-pushed
the
fix/TT-4224-ssl-redirect
branch
2 times, most recently
from
dc69471
to
3aa3858
Compare
Previously, our default configuration say that even if you enable TLS, we don't redirect HTTP to HTTPS. By default (without our overwrite config) nginx says: ``` By default the controller redirects (308) to HTTPS if TLS is enabled for that ingress. ``` https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#server-side-https-enforcement-through-redirect So both case: * customer keep default and use HTTP * customer only enable TLS will be handled correctly with default nginx configuration. As we add nginx.ingress.kubernetes.io/ssl-redirect: "false" which is ok by default without TLS. This mean that even if we enable TLS, the redirection is still disabled. My proposal is to remove our default setting and keep the nginx default one to make both case (TLS or not) work properly: enable redirection only if TLS is used. APIM-4817 TT-4224
passionne
force-pushed
the
fix/TT-4224-ssl-redirect
branch
from
3aa3858
to
9ea7d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-4817
Description
Previously, our default configuration say that even if you enable TLS, we don't redirect HTTP to HTTPS.
By default (without our overwrite config) nginx says:
https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#server-side-https-enforcement-through-redirect
So both case:
will be handled correctly with default nginx configuration.
As we add nginx.ingress.kubernetes.io/ssl-redirect: "false" which is ok by default without TLS.
This mean that even if we enable TLS, the redirection is still disabled.
My proposal is to remove our default setting and keep the nginx default one to make both case (TLS or not) work properly:
enable redirection only if TLS is used.