-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Impl Rollback for API V4 #7352
Conversation
2256df8
to
ed20793
Compare
ed20793
to
d8935f8
Compare
Passing run #1337 ↗︎
Details:
Review all test suite changes for PR #7352 ↗︎ |
afc11a1
to
4800a79
Compare
4800a79
to
3c46379
Compare
📝 As I'll be on vacation 🌴 for 3 weeks, don't hesitate to add a comment and make the change if possible of course. 🥺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments and questions.
I pushed some commits to resolve my refactoring suggestion, we can discuss it
...-service/src/main/java/io/gravitee/apim/core/plan/domain_service/ClosePlanDomainService.java
Outdated
Show resolved
Hide resolved
...im-rest-api-service/src/main/java/io/gravitee/apim/core/api/use_case/RollbackApiUseCase.java
Outdated
Show resolved
Hide resolved
.../gravitee-apim-rest-api-service/src/main/java/io/gravitee/apim/infra/adapter/ApiAdapter.java
Show resolved
Hide resolved
...ce/src/main/java/io/gravitee/apim/infra/domain_service/api/RollbackApiDomainServiceImpl.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/io/gravitee/apim/infra/domain_service/api/RollbackApiDomainServiceImpl.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/io/gravitee/apim/infra/domain_service/api/RollbackApiDomainServiceImpl.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/io/gravitee/apim/infra/domain_service/api/RollbackApiDomainServiceImpl.java
Outdated
Show resolved
Hide resolved
...est-api-service/src/test/java/io/gravitee/apim/core/api/use_case/RollbackApiUseCaseTest.java
Show resolved
Hide resolved
24c41da
to
6cdcb80
Compare
...im-rest-api-service/src/main/java/io/gravitee/apim/core/api/use_case/RollbackApiUseCase.java
Outdated
Show resolved
Hide resolved
...-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/apim/core/plan/model/Plan.java
Outdated
Show resolved
Hide resolved
...service/src/main/java/io/gravitee/apim/core/api/domain_service/RollbackApiDomainService.java
Outdated
Show resolved
Hide resolved
6cdcb80
to
1fc6df8
Compare
1fc6df8
to
1fe9991
Compare
Issue
https://gravitee.atlassian.net/browse/APIM-3958
Description
Impl rollback for API V4
Additional context
Screen.Recording.2024-04-29.at.09.01.26.mov
📚 View the storybook of this branch here
🏗️ Your changes can be tested here and will be available soon:
Console: https://pr.team-apim.gravitee.dev/7352/console
Portal: https://pr.team-apim.gravitee.dev/7352/portal
Management-api: https://pr.team-apim.gravitee.dev/7352/api/management
Gateway v4: https://pr.team-apim.gravitee.dev/7352
Gateway v3: https://pr.gateway-v3.team-apim.gravitee.dev/7352