Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Impl Rollback for API V4 #7352

Merged
merged 9 commits into from
May 21, 2024
Merged

Feat: Impl Rollback for API V4 #7352

merged 9 commits into from
May 21, 2024

Conversation

ThibaudAV
Copy link
Contributor

@ThibaudAV ThibaudAV commented Apr 26, 2024

Issue

https://gravitee.atlassian.net/browse/APIM-3958

Description

Impl rollback for API V4

Additional context

image

Screen.Recording.2024-04-29.at.09.01.26.mov

📚  View the storybook of this branch here

🏗️ Your changes can be tested here and will be available soon:
Console: https://pr.team-apim.gravitee.dev/7352/console
Portal: https://pr.team-apim.gravitee.dev/7352/portal
Management-api: https://pr.team-apim.gravitee.dev/7352/api/management
Gateway v4: https://pr.team-apim.gravitee.dev/7352
Gateway v3: https://pr.gateway-v3.team-apim.gravitee.dev/7352

@gravitee-io gravitee-io deleted a comment from mergify bot Apr 26, 2024
@ThibaudAV ThibaudAV force-pushed the APIM-3958-run-e2e branch 2 times, most recently from 2256df8 to ed20793 Compare April 26, 2024 13:57
@ThibaudAV ThibaudAV changed the title Apim 3958 run e2e Feat: Impl Rollback for API V4 Apr 26, 2024
Copy link

cypress bot commented Apr 26, 2024

Passing run #1337 ↗︎

0 82 8 0 Flakiness 0

Details:

fix(test): fix update federated plan use case test for general condition
Project: APIM UI Tests Commit: 1fe999178e
Status: Passed Duration: 07:03 💡
Started: May 21, 2024 8:40 AM Ended: May 21, 2024 8:47 AM

Review all test suite changes for PR #7352 ↗︎

@ThibaudAV ThibaudAV force-pushed the APIM-3958-run-e2e branch 3 times, most recently from afc11a1 to 4800a79 Compare April 26, 2024 16:02
@ThibaudAV ThibaudAV marked this pull request as ready for review April 29, 2024 06:51
@ThibaudAV ThibaudAV requested a review from a team as a code owner April 29, 2024 06:51
@ThibaudAV
Copy link
Contributor Author

📝 As I'll be on vacation 🌴 for 3 weeks, don't hesitate to add a comment and make the change if possible of course. 🥺
Otherwise I'll take care of it when I get back 🔙

Copy link
Member

@ytvnr ytvnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments and questions.
I pushed some commits to resolve my refactoring suggestion, we can discuss it

@ThibaudAV ThibaudAV requested a review from ytvnr May 21, 2024 09:22
@ThibaudAV ThibaudAV added the ready_to_test Push the code from the PR into a dedicated environment label May 21, 2024
@ThibaudAV ThibaudAV merged commit 559cfa4 into master May 21, 2024
56 checks passed
@ThibaudAV ThibaudAV deleted the APIM-3958-run-e2e branch May 21, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready_to_test Push the code from the PR into a dedicated environment
Projects
None yet
2 participants