feat: access points synchronization #7380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlomasney
force-pushed
the
cj-1754-access-points-sync
branch
from
b304c10
to
5127f7e
Compare
josephlomasney
commented
May 2, 2024
...c/main/java/io/gravitee/apim/infra/crud_service/access_point/AccessPointCrudServiceImpl.java
Outdated
Show resolved
Hide resolved
josephlomasney
force-pushed
the
cj-1754-access-points-sync
branch
2 times, most recently
from
e32d55c
to
6d8b0b6
Compare
guillaumelamirand
requested changes
May 3, 2024
...s-api/src/main/java/io/gravitee/gateway/handlers/accesspoint/manager/AccessPointManager.java
Outdated
Show resolved
Hide resolved
...i/src/main/java/io/gravitee/gateway/handlers/accesspoint/manager/AccessPointManagerImpl.java
Show resolved
Hide resolved
...ain/java/io/gravitee/gateway/services/sync/process/distributed/mapper/AccessPointMapper.java
Show resolved
Hide resolved
...in/java/io/gravitee/gateway/services/sync/process/repository/fetcher/AccessPointFetcher.java
Outdated
Show resolved
Hide resolved
...in/java/io/gravitee/gateway/services/sync/process/repository/fetcher/AccessPointFetcher.java
Outdated
Show resolved
Hide resolved
...teway/services/sync/process/repository/synchronizer/accesspoint/AccessPointSynchronizer.java
Outdated
Show resolved
Hide resolved
...teway/services/sync/process/repository/synchronizer/accesspoint/AccessPointSynchronizer.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/gravitee/apim/infra/crud_service/access_point/AccessPointCrudServiceImpl.java
Outdated
Show resolved
Hide resolved
josephlomasney
force-pushed
the
cj-1754-access-points-sync
branch
3 times, most recently
from
b2d83fb
to
56eaefe
Compare
josephlomasney
force-pushed
the
cj-1754-access-points-sync
branch
2 times, most recently
from
2ad23c9
to
0950239
Compare
|
@guillaumelamirand Thanks for the comments, I have added a new commit where I have adapted the code to use events for deploy and undeploy instead of just looking at the repository and I've also made changes for other comments. I'm going to work on tests but if you could have a look at the changes that would be great (to note there is some code on the repository that isn't needed anymore if keep the new event sync approach which I will then remove) |
josephlomasney
force-pushed
the
cj-1754-access-points-sync
branch
from
0950239
to
8fbb6fb
Compare
...i/src/main/java/io/gravitee/gateway/handlers/accesspoint/manager/AccessPointManagerImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/gravitee/apim/infra/crud_service/access_point/AccessPointCrudServiceImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/gravitee/apim/infra/crud_service/access_point/AccessPointCrudServiceImpl.java
Outdated
Show resolved
Hide resolved
|
I had a look at the changes. I am quite ok with them however I think they will be a issue with the use of DELETE/CREATE event where during a small time frame api with return 404. It should be better to use a UPDATE Event to first deploy the new access point and then remove the old one on gateway side. |
josephlomasney
force-pushed
the
cj-1754-access-points-sync
branch
12 times, most recently
from
40bd8ec
to
5e86b1d
Compare
josephlomasney
force-pushed
the
cj-1754-access-points-sync
branch
8 times, most recently
from
8e6fc01
to
6648dea
Compare
...va/io/gravitee/repository/mongodb/management/internal/domain/AccessPointMongoRepository.java
Outdated
Show resolved
Hide resolved
...va/io/gravitee/repository/mongodb/management/internal/domain/AccessPointMongoRepository.java
Outdated
Show resolved
Hide resolved
...va/io/gravitee/repository/mongodb/management/internal/domain/AccessPointMongoRepository.java
Outdated
Show resolved
Hide resolved
guillaumelamirand
approved these changes
May 22, 2024
josephlomasney
force-pushed
the
cj-1754-access-points-sync
branch
from
12c5771
to
8be11e4
Compare
josephlomasney
force-pushed
the
cj-1754-access-points-sync
branch
from
8be11e4
to
8afdd30
Compare
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/CJ-1748
https://gravitee.atlassian.net/browse/CJ-1754
Description
Context in this epic - https://gravitee.atlassian.net/browse/CJ-1748
Gateway synchronization of access points, only synchronization in this PR, actual usage of the access points not implemented yet
📚 View the storybook of this branch here