Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enrich additional info from var env for cloud #7490

Merged
merged 1 commit into from
May 21, 2024

Conversation

gcusnieux
Copy link
Member

@gcusnieux gcusnieux commented May 16, 2024

Issue

https://gravitee.atlassian.net/browse/CJ-1191

Description

A small description of what you did in that PR.

Additional context

@gcusnieux gcusnieux force-pushed the cj-1772-enrich-information-sent-to-cloud branch from b95ad3e to 1be432d Compare May 16, 2024 13:30
@gcusnieux gcusnieux marked this pull request as ready for review May 16, 2024 14:36
@gcusnieux gcusnieux requested a review from a team as a code owner May 16, 2024 14:36
Copy link
Contributor

@jgiovaresco jgiovaresco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand you will also need to update the Helm chart to support the new property 🤔 Did you check this part?

@gcusnieux
Copy link
Member Author

From what I understand you will also need to update the Helm chart to support the new property 🤔 Did you check this part?

yes, that's true, but it's the platform team that has to do it https://gravitee.atlassian.net/browse/TT-4674

@jhaeyaert
Copy link
Contributor

From what I understand you will also need to update the Helm chart to support the new property 🤔 Did you check this part?

yes, that's true, but it's the platform team that has to do it https://gravitee.atlassian.net/browse/TT-4674

I think it will be managed through env variables as there is no real external usage see:

As we don’t have external usage, we will use environment variable, something like this:

gravitee_installation_additionalInformation_0_name: cp-id
gravitee_installation_additionalInformation_0_value: efdab34c
gravitee_installation_additionalInformation_1_name: provider
gravitee_installation_additionalInformation_1_value: az

@gcusnieux
Copy link
Member Author

gcusnieux commented May 21, 2024

Yes it's true @jhaeyaert someone can approve @jgiovaresco 🙏 ?

Copy link
Contributor

@jhaeyaert jhaeyaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think you'll need an approval from an APIM guy (and you have Sonar issue that could block the merge)

@gcusnieux gcusnieux force-pushed the cj-1772-enrich-information-sent-to-cloud branch from 1be432d to efa351e Compare May 21, 2024 13:28
@gcusnieux
Copy link
Member Author

LGTM but I think you'll need an approval from an APIM guy (and you have Sonar issue that could block the merge)

Ok thx, I added a test on multi-tenant part 😅

@gcusnieux
Copy link
Member Author

What about integration tests ? It's not stable ?

@gcusnieux gcusnieux force-pushed the cj-1772-enrich-information-sent-to-cloud branch from efa351e to e8e3a4e Compare May 21, 2024 14:22
@gcusnieux gcusnieux merged commit f969825 into master May 21, 2024
27 checks passed
@gcusnieux gcusnieux deleted the cj-1772-enrich-information-sent-to-cloud branch May 21, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants