-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enrich additional info from var env for cloud #7490
Conversation
b95ad3e
to
1be432d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand you will also need to update the Helm chart to support the new property 🤔 Did you check this part?
yes, that's true, but it's the platform team that has to do it https://gravitee.atlassian.net/browse/TT-4674 |
I think it will be managed through env variables as there is no real external usage see:
|
Yes it's true @jhaeyaert someone can approve @jgiovaresco 🙏 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I think you'll need an approval from an APIM guy (and you have Sonar issue that could block the merge)
1be432d
to
efa351e
Compare
Ok thx, I added a test on multi-tenant part 😅 |
What about integration tests ? It's not stable ? |
efa351e
to
e8e3a4e
Compare
Issue
https://gravitee.atlassian.net/browse/CJ-1191
Description
A small description of what you did in that PR.
Additional context