feat(service): Include v4 APIs in Categories #7504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illichso
force-pushed
the
APIM-4851-include-v4-apis-in-categories-run-e2e
branch
2 times, most recently
from
21d4a82
to
5aa733d
Compare
Passing run #1384 ↗︎
Details:
Review all test suite changes for PR #7504 ↗︎ |
|||||||||||||||
jourdiw
reviewed
May 17, 2024
...apim-rest-api-service/src/main/java/io/gravitee/apim/core/api/use_case/ImportCRDUseCase.java
Outdated
Show resolved
Hide resolved
...-api-service/src/main/java/io/gravitee/apim/core/api/use_case/UpdateFederatedApiUseCase.java
Outdated
Show resolved
Hide resolved
...t-api-service/src/main/java/io/gravitee/rest/api/service/v4/impl/ApiCategoryServiceImpl.java
Outdated
Show resolved
Hide resolved
...-service/src/test/java/io/gravitee/apim/core/api/use_case/UpdateFederatedApiUseCaseTest.java
Outdated
Show resolved
Hide resolved
...i-service/src/main/java/io/gravitee/apim/core/api/domain_service/CreateApiDomainService.java
Outdated
Show resolved
Hide resolved
illichso
force-pushed
the
APIM-4851-include-v4-apis-in-categories-run-e2e
branch
7 times, most recently
from
a52dc30
to
d3c002a
Compare
illichso
force-pushed
the
APIM-4851-include-v4-apis-in-categories-run-e2e
branch
6 times, most recently
from
3f63734
to
057bea0
Compare
jourdiw
reviewed
May 21, 2024
...i-service/src/main/java/io/gravitee/apim/core/api/domain_service/CreateApiDomainService.java
Outdated
Show resolved
Hide resolved
...apim-rest-api-service/src/main/java/io/gravitee/apim/core/api/use_case/ImportCRDUseCase.java
Outdated
Show resolved
Hide resolved
illichso
force-pushed
the
APIM-4851-include-v4-apis-in-categories-run-e2e
branch
7 times, most recently
from
239c11a
to
21a4695
Compare
illichso
force-pushed
the
APIM-4851-include-v4-apis-in-categories-run-e2e
branch
2 times, most recently
from
1e1f784
to
a31a4cb
Compare
jourdiw
approved these changes
May 22, 2024
...-api-service/src/main/java/io/gravitee/apim/core/api/use_case/UpdateFederatedApiUseCase.java
Show resolved
Hide resolved
...t-api-service/src/main/java/io/gravitee/rest/api/service/v4/impl/ApiCategoryServiceImpl.java
Outdated
Show resolved
Hide resolved
illichso
force-pushed
the
APIM-4851-include-v4-apis-in-categories-run-e2e
branch
6 times, most recently
from
d60f857
to
d4d0b77
Compare
jourdiw
reviewed
May 24, 2024
...im-rest-api-service/src/main/java/io/gravitee/rest/api/service/converter/CategoryMapper.java
Show resolved
Hide resolved
...im-rest-api-service/src/main/java/io/gravitee/rest/api/service/converter/CategoryMapper.java
Show resolved
Hide resolved
...ee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/impl/ApiServiceImpl.java
Show resolved
Hide resolved
...apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/v4/impl/ApiServiceImpl.java
Outdated
Show resolved
Hide resolved
...apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/v4/impl/ApiServiceImpl.java
Outdated
Show resolved
Hide resolved
...est-api-service/src/test/java/io/gravitee/apim/core/api/use_case/CreateV4ApiUseCaseTest.java
Outdated
Show resolved
Hide resolved
...service/src/test/java/io/gravitee/apim/core/api/use_case/ImportApiDefinitionUseCaseTest.java
Outdated
Show resolved
Hide resolved
...-rest-api-service/src/test/java/io/gravitee/apim/core/api/use_case/ImportCRDUseCaseTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/io/gravitee/apim/core/integration/use_case/IngestIntegrationApisUseCaseTest.java
Outdated
Show resolved
Hide resolved
illichso
force-pushed
the
APIM-4851-include-v4-apis-in-categories-run-e2e
branch
4 times, most recently
from
78a8af0
to
8414772
Compare
jourdiw
approved these changes
May 24, 2024
illichso
force-pushed
the
APIM-4851-include-v4-apis-in-categories-run-e2e
branch
from
8414772
to
6589a77
Compare
… responds with category key
illichso
force-pushed
the
APIM-4851-include-v4-apis-in-categories-run-e2e
branch
from
6589a77
to
dba040e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-4851
Description
Make sure we create and update apis with categories ids, not categories keys
Additional context
📚 View the storybook of this branch here