-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Remove batching_regex as arg to FilePathDataConnectors #9715
base: develop
Are you sure you want to change the base?
[FEATURE] Remove batching_regex as arg to FilePathDataConnectors #9715
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9715 +/- ##
============================================
- Coverage 82.55% 64.63% -17.92%
============================================
Files 511 509 -2
Lines 46482 46479 -3
============================================
- Hits 38371 30042 -8329
- Misses 8111 16437 +8326
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…egex from LegacyBatchDefinition
…only' into f/v1-274/add_batching_regex_to_legacy_batch_definition
This PR removes
batching_regex
as a parameter toFilePathDataConnector
and any inheriting classes.previous work