Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Rename generic Partitioner union to ColumnPartitioner #9851

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

joshua-stauffer
Copy link
Member

We have a set of backend-agnostic partitioners in core, which split data on column. Now that we've added another set of partitioners which split data by file name (RegexPartitioner), we need to disambiguate by renaming Partitioner to ColumnPartitioner.

This PR also removes partitioners which we do not support, i.e. partitioners which are not time based.

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit b92c6b2
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6632a9afb60d6c000882021c
😎 Deploy Preview https://deploy-preview-9851.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.13%. Comparing base (1610eb9) to head (b92c6b2).
Report is 1 commits behind head on develop.

Files Patch % Lines
...pectations/datasource/fluent/invalid_datasource.py 50.00% 1 Missing ⚠️
...xpectations/datasource/fluent/pandas_datasource.py 0.00% 1 Missing ⚠️
...expectations/datasource/fluent/spark_datasource.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9851      +/-   ##
===========================================
- Coverage    81.21%   81.13%   -0.09%     
===========================================
  Files          502      502              
  Lines        44687    44669      -18     
===========================================
- Hits         36293    36241      -52     
- Misses        8394     8428      +34     
Flag Coverage Δ
3.10 65.76% <63.63%> (+0.08%) ⬆️
3.11 65.76% <63.63%> (+0.08%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.40% <63.63%> (-0.09%) ⬇️
3.11 aws_deps 44.26% <63.63%> (-0.03%) ⬇️
3.11 big 59.48% <63.63%> (-0.02%) ⬇️
3.11 databricks 45.35% <63.63%> (-0.03%) ⬇️
3.11 filesystem 62.24% <63.63%> (-0.02%) ⬇️
3.11 mssql 48.09% <63.63%> (-0.03%) ⬇️
3.11 mysql 48.15% <63.63%> (-0.03%) ⬇️
3.11 postgresql 51.69% <72.72%> (-0.14%) ⬇️
3.11 snowflake 45.95% <63.63%> (-0.03%) ⬇️
3.11 spark 58.08% <63.63%> (-0.02%) ⬇️
3.11 trino 51.12% <63.63%> (-0.02%) ⬇️
3.8 65.78% <63.63%> (+0.08%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.41% <63.63%> (-0.09%) ⬇️
3.8 aws_deps 44.28% <63.63%> (-0.03%) ⬇️
3.8 big 59.48% <63.63%> (-0.02%) ⬇️
3.8 databricks 45.36% <63.63%> (-0.03%) ⬇️
3.8 filesystem 62.25% <63.63%> (-0.02%) ⬇️
3.8 mssql 48.08% <63.63%> (-0.03%) ⬇️
3.8 mysql 48.13% <63.63%> (-0.03%) ⬇️
3.8 postgresql 51.68% <72.72%> (-0.14%) ⬇️
3.8 snowflake 45.96% <63.63%> (-0.03%) ⬇️
3.8 spark 58.03% <63.63%> (-0.02%) ⬇️
3.8 trino 51.11% <63.63%> (-0.02%) ⬇️
3.9 65.77% <63.63%> (+0.08%) ⬆️
cloud 0.00% <0.00%> (ø)
docs-basic 52.16% <63.63%> (-0.04%) ⬇️
docs-creds-needed 53.26% <63.63%> (-0.04%) ⬇️
docs-spark 51.93% <63.63%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant