-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Rename generic Partitioner union to ColumnPartitioner #9851
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9851 +/- ##
===========================================
- Coverage 81.21% 81.13% -0.09%
===========================================
Files 502 502
Lines 44687 44669 -18
===========================================
- Hits 36293 36241 -52
- Misses 8394 8428 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We have a set of backend-agnostic partitioners in
core
, which split data on column. Now that we've added another set of partitioners which split data by file name (RegexPartitioner
), we need to disambiguate by renamingPartitioner
toColumnPartitioner
.This PR also removes partitioners which we do not support, i.e. partitioners which are not time based.