[MAINTENANCE] Remove context root directory search logic within SerializableDataContext
#9904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9904 +/- ##
===========================================
+ Coverage 77.28% 77.32% +0.03%
===========================================
Files 492 492
Lines 42006 41971 -35
===========================================
- Hits 32465 32453 -12
+ Misses 9541 9518 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…_expectations into m/_/patch_context_root_dir_search
billdirks
approved these changes
May 8, 2024
There was a problem hiding this comment.
Thanks for doing this! We should verify with @jcampbell that he is onboard with this change.
| ) or cls._search_gx_dir_for_context_yml( | ||
| search_start_dir=search_start_dir, gx_dir=cls._LEGACY_GX_DIR | ||
| directory_to_search=directory_to_search, gx_dir_name=cls._LEGACY_GX_DIR |
There was a problem hiding this comment.
I think we can get rid of this _LEGACY_GX_DIR also.
| ) | ||
|
|
||
| @classmethod | ||
| def _search_gx_dir_for_context_yml( | ||
| cls, search_start_dir: pathlib.Path, gx_dir: str | ||
| cls, directory_to_search: pathlib.Path, gx_dir_name: str |
There was a problem hiding this comment.
nit: This signature is kind of strange since one argument is a path and one is a str.
…_expectations into m/_/patch_context_root_dir_search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.18.x, the context would search up to 4 levels up in a file/directory structure to find a GX project. This feels a bit too magical and results in difficult to diagnose bugs.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!