Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset project as cleanup in empty_data_context #9909

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tyler-hoffman
Copy link
Contributor

The value from set_project persists between tests, which means that many of our tests only work because some other previous test had called set_project (likely indirectly via a fixture)

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented May 9, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 41b1ebe
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663ce635dec92d000821b74d

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants