[FEATURE] update slack renderer to new design #9919
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jshaikGX
force-pushed
the
f/PH-1240/slack_renderer_update
branch
from
50fab50
to
882c442
Compare
jshaikGX
force-pushed
the
f/PH-1240/slack_renderer_update
branch
from
026d002
to
e1d0f33
Compare
jshaikGX
force-pushed
the
f/PH-1240/slack_renderer_update
branch
from
321a16e
to
b59c95c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9919 +/- ##
===========================================
+ Coverage 77.33% 77.37% +0.03%
===========================================
Files 490 490
Lines 41659 41635 -24
===========================================
- Hits 32218 32213 -5
+ Misses 9441 9422 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| """ | ||
|
|
||
| expectation_suite_name = validation_result.suite_name | ||
| data_asset_name = validation_result.asset_name or "__no_data_asset_name__" |
There was a problem hiding this comment.
I think we should always have an asset_name - we may want to remove the property we have at the top level of the ExpectationSuiteValidationResult, add it as a param to the constructor, and make sure that whoever is creating the object is providing the necessary data
There was a problem hiding this comment.
will address this as a separate thing because editing the ExpectationSuiteValidationResult which will result in many TFs and code changes that I'd rather not make as part of this effort
| "type": "section", | ||
| "text": {"type": "plain_text", "text": "Runtime: 2024/04/01 08:51 PM"}, |
There was a problem hiding this comment.
Could we get a test with multiple assets? Additionally, could you add a screenshot of what that renders like?
There was a problem hiding this comment.
added another test in test_core_actions.py to cover this scenario
| return {"blocks": all_blocks} | ||
|
|
||
| def _build_header(self, name: str, success: bool, checkpoint_name: str) -> dict: | ||
| status = "Success :white_check_mark:" if success else "Failure :no_entry:" |
There was a problem hiding this comment.
Nit - could we move these Slack emojis to class vars? They're currently magic strings (I know I left it like this before)
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!