Revert version update of react-router-dom and history

[swaterkamp]

What:
Revert react-router-dom dependency version from 5.2.1 to 5.2.0
Revert history dependency version from 5.0.1 to 4.10.1

Why:
react-router-dom breaks our login page presumably due to a change of default behavior (remix-run/react-router#5362)
history breaks navigation almost completely

How:
Login and navigation is possible again

Checklist:

• Tests
• CHANGELOG Entry
• Labels for ports to other branches

[guidobouman]

Author of the change here: The 5.2.1 should only change that a click on a Link will not push a new entry to the history stack when a duplicate entry is already there. This makes the Link component behave the same as a native HTML anchor (<a>) tag. If it breaks your login, you were leaning on a bugged behaviour in React Router. (Maybe you used a Link where you needed a button?)

What I find more weird is that DependaBot did not touch your history package, but you do downgrade it. Is that correct?

[swaterkamp]

Thanks for pointing this out @guidobouman . Dependabot touched history a week before in #3133 and we suspected a possible interplay between these two packages. We needed a quick fix to be able to log in again, while we are aware of the fact, that we indeed possibly relied on buggy behavior in the past. This issue was on our list to be revisited, already, but I'll investigate this again now sooner than later.

[guidobouman]

Great to hear your extensive thoughts. All the best!