PLANET-5484 Build zip on tag #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inwerpsel
force-pushed
the
planet-5484
branch
from
80d597a
to
29dcbd0
Compare
Inwerpsel
commented
Sep 30, 2020
| - run: npm run build | ||
| - run: | ||
| name: "Remove files we don't want in the zip file." | ||
| command: rm -rf .circleci .git .githooks assets/src bin tests |
There was a problem hiding this comment.
I included the ones of which I was sure they wouldn't be needed in the zip. Maybe there's some others which would make sense to exclude here? The total zip size is currently about 2MB.
Inwerpsel
force-pushed
the
planet-5484
branch
from
29dcbd0
to
bec646d
Compare
* Same changes as were applied for master theme here greenpeace/planet4-master-theme#1182
Inwerpsel
force-pushed
the
planet-5484
branch
from
bec646d
to
05b64d0
Compare
comzeradd
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same changes as were applied for master theme here Planet 5484 create zip on tag planet4-master-theme#1182
Ref: https://jira.greenpeace.org/browse/PLANET-5484