Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include src in npm (for types) #601

Closed
wants to merge 2 commits into from
Closed

Conversation

IanVS
Copy link

@IanVS IanVS commented Sep 28, 2021

Summary

I tried to use version 6.0.0-alpha.0 to get the typescript definitions as added in #555, but they are in core/src, which is not currently included in the npm package. This change includes src, so that the types can be used by consuming packages.

This also fixes some types that were commented on in the PR but not addressed.

Test plan

I copied the /src folder into node_modules/@svgr/core/ and verified that types started working correctly in my consuming project.

@vercel
Copy link

vercel bot commented Sep 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gregberge/svgr/2tTnbvGULQpMw4VJrfWgWJya4FxG
✅ Preview: https://svgr-git-fork-ianvs-expose-types-gregberge.vercel.app

@gregberge
Copy link
Owner

Fixed in b7db87f

@gregberge gregberge closed this Oct 1, 2021
@IanVS
Copy link
Author

IanVS commented Oct 1, 2021

Just curious, what's the reason for committing directly instead of merging my PR? I would have liked to be considered a contributor to the project…

@IanVS IanVS deleted the expose-types branch October 1, 2021 20:25
@gregberge
Copy link
Owner

Just curious, what's the reason for committing directly instead of merging my PR? I would have liked to be considered a contributor to the project…

In your PR you includes everything under src, but we only need one file in lib. Your PR is wrong, I wanted to go faster so I made the fix directly. Anyway, thanks for your work 🤗

@SimenB
Copy link

SimenB commented Oct 26, 2021

@gregberge can you publish as well?

@gregberge
Copy link
Owner

@SimenB I have a few work ongoing on v6, please be patient :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants