Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make randomOrder configuration, allowing tests to be run in any order… #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashleyfrieze
Copy link
Contributor

… within their part of the tree.

A solution to #47

@tjarratt - what do you think?

@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

Merging #128 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
+ Coverage     99.45%   99.47%   +0.01%     
- Complexity      349      361      +12     
============================================
  Files            43       45       +2     
  Lines           739      760      +21     
  Branches         22       22              
============================================
+ Hits            735      756      +21     
  Partials          4        4
Impacted Files Coverage Δ Complexity Δ
.../java/com/greghaskins/spectrum/internal/Suite.java 100% <100%> (ø) 57 <3> (+2) ⬆️
.../main/java/com/greghaskins/spectrum/Configure.java 100% <100%> (ø) 14 <2> (+2) ⬆️
...ctrum/internal/configuration/BlockRandomOrder.java 100% <100%> (ø) 7 <7> (?)
...ghaskins/spectrum/internal/ExecutionSequencer.java 100% <100%> (ø) 1 <1> (?)

@marioluan
Copy link

marioluan commented Feb 10, 2018

I'm really looking forward to having this feature pushed.

@greghaskins @tjarratt Any chances for this to get merged?

@ashleyfrieze
Copy link
Contributor Author

I would like to retest this with the gherkin style tests to make sure it can’t scramble them.

});
});
}));
});
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashleyfrieze Do you imagine needing more than these specs here ☝️ to sufficiently test the Gherkin-style DSL? This scenario seems pretty straightforward to me. I guess you might have a mixed describe where some pieces run in random order, but the right things (given/when/then) stay in the right order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These do look like they cover the scenario. I've a funny feeling there was something else worrying me about the feature, perhaps relating back to the bug I found in the gherkin tests. If you're going to merge PR #127, why don't we review this again after rebasing?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. We'll look at it again after #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants