Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snapshot tests #451

Closed
kaitmore opened this issue May 20, 2019 · 2 comments
Closed

Fix snapshot tests #451

kaitmore opened this issue May 20, 2019 · 2 comments
Labels
1.0

Comments

@kaitmore
Copy link
Contributor

Updating to v4 broke our snapshot testing. We should keep an eye on this issue and update jest-styled-components and enzyme when it's resolved: styled-components/jest-styled-components#191
@shanberg
Copy link
Contributor

In the meantime, should we allow pushing up changes with broken snapshots?

@kaitmore
Copy link
Contributor Author

I think "broken" was the wrong word.. more like "useless" :) Snapshot tests should still pass.

@shanberg shanberg added the 1.0 label May 31, 2019
@kaitmore kaitmore mentioned this issue Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shanberg @kaitmore