feat: fix testing, update deps #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitmore
commented
Jul 8, 2019
shanberg
added a commit
that referenced
this pull request
Jul 10, 2019
* chore: update sc to v4 (#450) * feat: update to scv4 * test: update snaps * feat: add global styles (#443) * feat: add new global styles * chore: package-lock * feat: add custom properties from theme to GlobalStyle * feat: document new variables in Styles story * fix: fix typo in globalStyles * test: update snapshots * feat: include global style in StoryContainer * feat: normalize component name to GlobalStyles, add box-sizing * fix: restore proper filename casing * feat: improve default style for horizontal rule * fix: properly add renamed file this time * fix: rename global styles * fix: rename global styles * feat: fix and polish checkbox and radio inputs (#453) * feat: export style variables and functions (#422) * feat: fluid CSS solution to the breadcrumb overflow problem (#402) * feat: fluid CSS solution to the breadcrumb overflow problem * fix: removing test styles * test: update snapshots * test: remove OBE tests * fix: clean up javascript, remove unneeded props * test: update tests and add storybook story * feat: customizable footer (#423) * feat: customizable footer * test: refactor AppFooter tests * fix: footer render statement * fix: breadcrumbs error (#428) * fix: error in breadcrumbs component * fix: use index in key * fix: blank page when clicking anchor links in styles story (#425) * feat: update storybook to 5 (#429) * feat: update storybook to 5 * feat: give Readouts stories default color to prevent storybook crash * feat: add minimal grey matter theme * fix: minor console errors * chore: update storybook patch version * fix: workaround for spinner issue in chrome (#430) * fix: workaround for svg issue in chrome * test: update snapshots * docs: update contributing guide (#426) * Update contributing guide * Update considerations text * Update component guideline content * Clarify component naming guideline * Update guideline text * feat: add double chevrons for up and down directions (#431) * feat: add prop to buttons to allow custom color (#437) * feat: add prop to buttons to allow custom color * fix: use color instead of text for color prop * chore: update checkbox to use theme colors * fix: make checkmark sizing consistent * feat: add hover styles for checkmark inputs * feat: polish checkbox and radio inputs * test: update snapshots * feat: polish storybook UX (#454) * feat: export style variables and functions (#422) * feat: fluid CSS solution to the breadcrumb overflow problem (#402) * feat: fluid CSS solution to the breadcrumb overflow problem * fix: removing test styles * test: update snapshots * test: remove OBE tests * fix: clean up javascript, remove unneeded props * test: update tests and add storybook story * feat: customizable footer (#423) * feat: customizable footer * test: refactor AppFooter tests * fix: footer render statement * fix: breadcrumbs error (#428) * fix: error in breadcrumbs component * fix: use index in key * fix: blank page when clicking anchor links in styles story (#425) * feat: update storybook to 5 (#429) * feat: update storybook to 5 * feat: give Readouts stories default color to prevent storybook crash * feat: add minimal grey matter theme * fix: minor console errors * chore: update storybook patch version * fix: workaround for spinner issue in chrome (#430) * fix: workaround for svg issue in chrome * test: update snapshots * docs: update contributing guide (#426) * Update contributing guide * Update considerations text * Update component guideline content * Clarify component naming guideline * Update guideline text * feat: add double chevrons for up and down directions (#431) * feat: add prop to buttons to allow custom color (#437) * feat: add prop to buttons to allow custom color * fix: use color instead of text for color prop * feat: update to styled-components 4 * feat: add new global styles * chore: package-lock * feat: add custom properties from theme to GlobalStyle * feat: document new variables in Styles story * fix: fix typo in globalStyles * test: update snapshots * feat: include global style in StoryContainer * feat: normalize component name to GlobalStyles, add box-sizing * feat: better storybook readability * Rename globalStyles.js to GlobalStyles.js * Rename globalstyles.stories.js to Globalstyles.stories.js * fix: add missing files * fix: add missing files * fix: duplicate import * fix: fix theme background color applying to entire storycontainer (#455) * feat: link checkmark color to checkmark input color (#459) * feat: link checkmark color to checkmark input color * test: update snaps * feat: AppFooter position should be neutral (#460) * feat: remove fancy positioning styles from appfooter * test: update snaps * feat: add wrapper div to appfooter story for better demonstration * Lower global link style specificity (#461) `a:link` had unintended consequences over `a`, including breaking AppFooter link colors. It’s preferable to make fewer assumptions at the global level than to force more overrides down the tree. * fix: stabilize radiobox mark (#463) * fix: stabilize RadioBox mark on rapid click in Safari * refactor: clean up a few unnecessary lines in inputbox component * test: update snaps * feat: replace old AppFooter logo (#462) * feat: replace footer logo and update color usage * feat: leaner styles imposed on logo * refactor: reduce styles needed for footer logo * test: update snaps * fix: add missing alt tag * fix: make button size generator use proper font sizes (#476) * feat: add theme story (#478) * feat: add canvas for theme testing * feat: improve content represented in theme story * feat: add link to theming documentation * refactor: rename styleVariables to theme (#477) * feat: show all props gallery for button component (#475) * feat: show all props gallery for button component * fix: add tooltip to button prop gallery * refactor: remove stylevariables outside of theme (#472) * refactor: remove unconflicted stylevar exports * refactor: extract stylevariables usage into theme values * refactor: trying to make StyledSVG work again * chore: removing commented code * fix: make icons work again * test: update snaps * fix: resolve a couple non-theme value issues in button utils * test: fix failing tests * fix: remove zombie and commented code * test: replace incorrect test renderer * test: update snaps * fix: minor refactor to generateButtonSize * refactor: combine theme font variables (#473) * refactor: simplify font stacks * test: update snaps * fix: fix incorrect font import * fix: replace brand color with highlight color (#480) * fix: remove unused secondary typefrom button (#481) * chore: remove appheader (#485) * chore: update deps (#486) * feat: update babel packages, sc, and enzyme * chore: update storybook and addons * chore: update polished * fix: update commitlint * chore: update husky * refactor: normalize storybook stories (#487) * refactor: normalize story naming and implementation * refactor: pull group components out to top level * test: update snaps * refactor: bring navcardgroup up to main level * fix: fix some failing tests * test: update snaps * refactor: remove unused 'prefix' and 'suffix' features from Button (#489) * refactor: remove unused 'prefix' and 'suffix' features from Button * test: update snaps * fix: add missing stories (#494) * feat: add typical checkbox story * feat: add typical input field story * feat: add typical inputrange story * test: update snaps * chore: update dependencies (#493) * refactor: wrappers just wrap (#491) * refactor: update theme values (#490) * feat: find-replace theme const names * feat: add new color theme values * feat: block in new values to dark theme * refactor: replace theme values in both themes * refactor: update theme value references in global styles * refactor: appfooter uses updated theme * refactor: breadcrumbs use color instead of opacity * feat: update stylevars story with new values * test: update snaps * feat: improved dark theme consistency and contrast * feat: replace instances of opacity for text with color for text * fix: inputs and form elements have correct radios * fix: fix other component radii * feat: global style includes line-height * feat: better theme values * feat: clearer design tokens page * test: update snaps * fix: fix some minor readability issues in theme and inputs * test: update snaps * feat: remove Avenir Next from brand font stack * feat: update README with new theme prototype * refactor: minor cleanup to navcard * chore: remove unused imports * test: update snaps * feat: navcardgroup prefers dark theme * test: update snaps * fix: fix incorrect default theme keyline color * test: update snaps * refactor: move form components to top level (#492) * refactor: form components live at top level, subcomponents go in utils * fix: fix typod import * fix: remove zombie folder * fix: add missing stories (#494) * feat: add typical checkbox story * feat: add typical input field story * feat: add typical inputrange story * test: update snaps * chore: update dependencies (#493) * refactor: wrappers just wrap (#491) * feat: defaultprops and component order (#484) * feat: batch of cleanup changes * fix: replace defaultprops theme * feat: add defaultprops for all non-required props * test: update snaps * fix: remove zombie appheader * test: un-break snapshots * fix: add missing theme default * fix: remove duplicate theme import * test: update snaps * chore: refreshed package-lock * test: update snaps * refactor: no null defaultprops * refactor: custom proptypes go in utils * refactor: nodePropType = node, used by button now too * fix: define button clickation proptype exclusively * feat: better define input types * fix: proptypes.func not .function * refactor: remove undefined defaultprops * test: update snaps * fix: add missing displayNames to inputs * test: update snaps * chore: update from develop * fix: update Collapse to styled-components 4 * chore: update snaps * feat: updated icons component (#495) * feat: export style variables and functions (#422) * feat: fluid CSS solution to the breadcrumb overflow problem (#402) * feat: fluid CSS solution to the breadcrumb overflow problem * fix: removing test styles * test: update snapshots * test: remove OBE tests * fix: clean up javascript, remove unneeded props * test: update tests and add storybook story * feat: customizable footer (#423) * feat: customizable footer * test: refactor AppFooter tests * fix: footer render statement * fix: breadcrumbs error (#428) * fix: error in breadcrumbs component * fix: use index in key * fix: blank page when clicking anchor links in styles story (#425) * feat: update storybook to 5 (#429) * feat: update storybook to 5 * feat: give Readouts stories default color to prevent storybook crash * feat: add minimal grey matter theme * fix: minor console errors * chore: update storybook patch version * fix: workaround for spinner issue in chrome (#430) * fix: workaround for svg issue in chrome * test: update snapshots * docs: update contributing guide (#426) * Update contributing guide * Update considerations text * Update component guideline content * Clarify component naming guideline * Update guideline text * feat: add double chevrons for up and down directions (#431) * feat: add prop to buttons to allow custom color (#437) * feat: add prop to buttons to allow custom color * fix: use color instead of text for color prop * feat: add new icons to replace old icons * feat: support for custom svg * feat: better default fillopacity for svg icon * refactor: reorganize icon file * feat: improved stories for icon * refactor: remove propstypes from styledSVG, leave it to icon * refactor: leaner style declarations for styledsvg * feat: merging old and new icons * feat: add icon badge and new knobs * chore: update package-log * fix: fix a few merge issues * test: fix failing icon tests * test: fix tests * test: fix failing tests * fix: position icon badge above other content * fix: make sure svg gets proper fill opacity * feat: icon badges now mask glyph * feat: minor icon fixes * feat: better text position in icon story to show text-icon relationship * refactor: remove unused prop * test: update snap * chore: remove old icon set * feat: polish more icons and the icon story * feat: add summary icon * feat: add functions icon * feat: add GitHub, linked, negation, threads, twitter icons * fix: rename badge to hasBadge * test: update snap * chore: remove zombie files (#501) * refactor: consistent theme import style (#500) * refactor: restyle theme usage * test: fix failing checkbox wrapper test * test: fix failing test * chore: remove zombe files * fix: collapse should use correct theme values * fix: collapse component uses correct ref prop * chore: button label defaultProp * chore: check for undefined label in Button * fix: add default props to ReadoutGroup and ItemDisplay * fix: update spacingScale to use css property * fix: remove commented code, fix tabwrap attrs warning * fix: export GlobalStyles * fix: revert spacingScale change * fix: use different icon for collapse * fix: minor changes to checkbox layout styles * feat: add missing icons * feat: better readability for footer icons * fix: use css variables for spacingscale * feat: improve footer icons * fix: remove unneded style property from links * fix: delete iconbackground * fix: update template to use correct displayname * fix: replace impoperly-formatted icons * feat: fix testing, update deps (#506) * fix: update dependencies, add test util * fix: add comments * chore: update package-lock * chore: uninstall react-test-renderer * test: udpate snapshots * ci: add linting stage * ci: add missing require job * chore: fix all lint warnings * test: update Spinner test * test: update snaps and lint errors * fix: class to className * fix: hack for poor SVG rendering in Chrome * fix: readoutdisplay should now show proper colors * chore: add comment explaining id replacement * fix: remaining attrs refactors * fix: testUtils * fix: checkbox label layout * fix: error in testUtils * test: update snaps
kaitmore
pushed a commit
that referenced
this pull request
Jul 10, 2019
* fix: update webpack svg loader (#447) * feat: collapse (#498) * feat: initial accordion component * chore: rename collapse * test: update test * fix: add fallback for contentHeight * fix: update proptypes * fix: require children to be an element * fix: rename top-level export * chore: remove console log * test: dive past shallow wrapper * feat: add keyboard ctrls * fix: outline styles * test: add tests for subcomponents * fix: update keyboard controls * fix: remove opinionated styling * fix: add visibility hidden to collapsed content * feat: controllable collapse component (#505) * fix: implement controlled props * test: update tests * fix: add story text * feat: add knobs * fix: pass event to onClick * fix: refactor into a class component * test: update tests * chore: update storybook * fix: simplify getDerivedStateFromProps * feat: 1.0 (#499) * chore: update sc to v4 (#450) * feat: update to scv4 * test: update snaps * feat: add global styles (#443) * feat: add new global styles * chore: package-lock * feat: add custom properties from theme to GlobalStyle * feat: document new variables in Styles story * fix: fix typo in globalStyles * test: update snapshots * feat: include global style in StoryContainer * feat: normalize component name to GlobalStyles, add box-sizing * fix: restore proper filename casing * feat: improve default style for horizontal rule * fix: properly add renamed file this time * fix: rename global styles * fix: rename global styles * feat: fix and polish checkbox and radio inputs (#453) * feat: export style variables and functions (#422) * feat: fluid CSS solution to the breadcrumb overflow problem (#402) * feat: fluid CSS solution to the breadcrumb overflow problem * fix: removing test styles * test: update snapshots * test: remove OBE tests * fix: clean up javascript, remove unneeded props * test: update tests and add storybook story * feat: customizable footer (#423) * feat: customizable footer * test: refactor AppFooter tests * fix: footer render statement * fix: breadcrumbs error (#428) * fix: error in breadcrumbs component * fix: use index in key * fix: blank page when clicking anchor links in styles story (#425) * feat: update storybook to 5 (#429) * feat: update storybook to 5 * feat: give Readouts stories default color to prevent storybook crash * feat: add minimal grey matter theme * fix: minor console errors * chore: update storybook patch version * fix: workaround for spinner issue in chrome (#430) * fix: workaround for svg issue in chrome * test: update snapshots * docs: update contributing guide (#426) * Update contributing guide * Update considerations text * Update component guideline content * Clarify component naming guideline * Update guideline text * feat: add double chevrons for up and down directions (#431) * feat: add prop to buttons to allow custom color (#437) * feat: add prop to buttons to allow custom color * fix: use color instead of text for color prop * chore: update checkbox to use theme colors * fix: make checkmark sizing consistent * feat: add hover styles for checkmark inputs * feat: polish checkbox and radio inputs * test: update snapshots * feat: polish storybook UX (#454) * feat: export style variables and functions (#422) * feat: fluid CSS solution to the breadcrumb overflow problem (#402) * feat: fluid CSS solution to the breadcrumb overflow problem * fix: removing test styles * test: update snapshots * test: remove OBE tests * fix: clean up javascript, remove unneeded props * test: update tests and add storybook story * feat: customizable footer (#423) * feat: customizable footer * test: refactor AppFooter tests * fix: footer render statement * fix: breadcrumbs error (#428) * fix: error in breadcrumbs component * fix: use index in key * fix: blank page when clicking anchor links in styles story (#425) * feat: update storybook to 5 (#429) * feat: update storybook to 5 * feat: give Readouts stories default color to prevent storybook crash * feat: add minimal grey matter theme * fix: minor console errors * chore: update storybook patch version * fix: workaround for spinner issue in chrome (#430) * fix: workaround for svg issue in chrome * test: update snapshots * docs: update contributing guide (#426) * Update contributing guide * Update considerations text * Update component guideline content * Clarify component naming guideline * Update guideline text * feat: add double chevrons for up and down directions (#431) * feat: add prop to buttons to allow custom color (#437) * feat: add prop to buttons to allow custom color * fix: use color instead of text for color prop * feat: update to styled-components 4 * feat: add new global styles * chore: package-lock * feat: add custom properties from theme to GlobalStyle * feat: document new variables in Styles story * fix: fix typo in globalStyles * test: update snapshots * feat: include global style in StoryContainer * feat: normalize component name to GlobalStyles, add box-sizing * feat: better storybook readability * Rename globalStyles.js to GlobalStyles.js * Rename globalstyles.stories.js to Globalstyles.stories.js * fix: add missing files * fix: add missing files * fix: duplicate import * fix: fix theme background color applying to entire storycontainer (#455) * feat: link checkmark color to checkmark input color (#459) * feat: link checkmark color to checkmark input color * test: update snaps * feat: AppFooter position should be neutral (#460) * feat: remove fancy positioning styles from appfooter * test: update snaps * feat: add wrapper div to appfooter story for better demonstration * Lower global link style specificity (#461) `a:link` had unintended consequences over `a`, including breaking AppFooter link colors. It’s preferable to make fewer assumptions at the global level than to force more overrides down the tree. * fix: stabilize radiobox mark (#463) * fix: stabilize RadioBox mark on rapid click in Safari * refactor: clean up a few unnecessary lines in inputbox component * test: update snaps * feat: replace old AppFooter logo (#462) * feat: replace footer logo and update color usage * feat: leaner styles imposed on logo * refactor: reduce styles needed for footer logo * test: update snaps * fix: add missing alt tag * fix: make button size generator use proper font sizes (#476) * feat: add theme story (#478) * feat: add canvas for theme testing * feat: improve content represented in theme story * feat: add link to theming documentation * refactor: rename styleVariables to theme (#477) * feat: show all props gallery for button component (#475) * feat: show all props gallery for button component * fix: add tooltip to button prop gallery * refactor: remove stylevariables outside of theme (#472) * refactor: remove unconflicted stylevar exports * refactor: extract stylevariables usage into theme values * refactor: trying to make StyledSVG work again * chore: removing commented code * fix: make icons work again * test: update snaps * fix: resolve a couple non-theme value issues in button utils * test: fix failing tests * fix: remove zombie and commented code * test: replace incorrect test renderer * test: update snaps * fix: minor refactor to generateButtonSize * refactor: combine theme font variables (#473) * refactor: simplify font stacks * test: update snaps * fix: fix incorrect font import * fix: replace brand color with highlight color (#480) * fix: remove unused secondary typefrom button (#481) * chore: remove appheader (#485) * chore: update deps (#486) * feat: update babel packages, sc, and enzyme * chore: update storybook and addons * chore: update polished * fix: update commitlint * chore: update husky * refactor: normalize storybook stories (#487) * refactor: normalize story naming and implementation * refactor: pull group components out to top level * test: update snaps * refactor: bring navcardgroup up to main level * fix: fix some failing tests * test: update snaps * refactor: remove unused 'prefix' and 'suffix' features from Button (#489) * refactor: remove unused 'prefix' and 'suffix' features from Button * test: update snaps * fix: add missing stories (#494) * feat: add typical checkbox story * feat: add typical input field story * feat: add typical inputrange story * test: update snaps * chore: update dependencies (#493) * refactor: wrappers just wrap (#491) * refactor: update theme values (#490) * feat: find-replace theme const names * feat: add new color theme values * feat: block in new values to dark theme * refactor: replace theme values in both themes * refactor: update theme value references in global styles * refactor: appfooter uses updated theme * refactor: breadcrumbs use color instead of opacity * feat: update stylevars story with new values * test: update snaps * feat: improved dark theme consistency and contrast * feat: replace instances of opacity for text with color for text * fix: inputs and form elements have correct radios * fix: fix other component radii * feat: global style includes line-height * feat: better theme values * feat: clearer design tokens page * test: update snaps * fix: fix some minor readability issues in theme and inputs * test: update snaps * feat: remove Avenir Next from brand font stack * feat: update README with new theme prototype * refactor: minor cleanup to navcard * chore: remove unused imports * test: update snaps * feat: navcardgroup prefers dark theme * test: update snaps * fix: fix incorrect default theme keyline color * test: update snaps * refactor: move form components to top level (#492) * refactor: form components live at top level, subcomponents go in utils * fix: fix typod import * fix: remove zombie folder * fix: add missing stories (#494) * feat: add typical checkbox story * feat: add typical input field story * feat: add typical inputrange story * test: update snaps * chore: update dependencies (#493) * refactor: wrappers just wrap (#491) * feat: defaultprops and component order (#484) * feat: batch of cleanup changes * fix: replace defaultprops theme * feat: add defaultprops for all non-required props * test: update snaps * fix: remove zombie appheader * test: un-break snapshots * fix: add missing theme default * fix: remove duplicate theme import * test: update snaps * chore: refreshed package-lock * test: update snaps * refactor: no null defaultprops * refactor: custom proptypes go in utils * refactor: nodePropType = node, used by button now too * fix: define button clickation proptype exclusively * feat: better define input types * fix: proptypes.func not .function * refactor: remove undefined defaultprops * test: update snaps * fix: add missing displayNames to inputs * test: update snaps * chore: update from develop * fix: update Collapse to styled-components 4 * chore: update snaps * feat: updated icons component (#495) * feat: export style variables and functions (#422) * feat: fluid CSS solution to the breadcrumb overflow problem (#402) * feat: fluid CSS solution to the breadcrumb overflow problem * fix: removing test styles * test: update snapshots * test: remove OBE tests * fix: clean up javascript, remove unneeded props * test: update tests and add storybook story * feat: customizable footer (#423) * feat: customizable footer * test: refactor AppFooter tests * fix: footer render statement * fix: breadcrumbs error (#428) * fix: error in breadcrumbs component * fix: use index in key * fix: blank page when clicking anchor links in styles story (#425) * feat: update storybook to 5 (#429) * feat: update storybook to 5 * feat: give Readouts stories default color to prevent storybook crash * feat: add minimal grey matter theme * fix: minor console errors * chore: update storybook patch version * fix: workaround for spinner issue in chrome (#430) * fix: workaround for svg issue in chrome * test: update snapshots * docs: update contributing guide (#426) * Update contributing guide * Update considerations text * Update component guideline content * Clarify component naming guideline * Update guideline text * feat: add double chevrons for up and down directions (#431) * feat: add prop to buttons to allow custom color (#437) * feat: add prop to buttons to allow custom color * fix: use color instead of text for color prop * feat: add new icons to replace old icons * feat: support for custom svg * feat: better default fillopacity for svg icon * refactor: reorganize icon file * feat: improved stories for icon * refactor: remove propstypes from styledSVG, leave it to icon * refactor: leaner style declarations for styledsvg * feat: merging old and new icons * feat: add icon badge and new knobs * chore: update package-log * fix: fix a few merge issues * test: fix failing icon tests * test: fix tests * test: fix failing tests * fix: position icon badge above other content * fix: make sure svg gets proper fill opacity * feat: icon badges now mask glyph * feat: minor icon fixes * feat: better text position in icon story to show text-icon relationship * refactor: remove unused prop * test: update snap * chore: remove old icon set * feat: polish more icons and the icon story * feat: add summary icon * feat: add functions icon * feat: add GitHub, linked, negation, threads, twitter icons * fix: rename badge to hasBadge * test: update snap * chore: remove zombie files (#501) * refactor: consistent theme import style (#500) * refactor: restyle theme usage * test: fix failing checkbox wrapper test * test: fix failing test * chore: remove zombe files * fix: collapse should use correct theme values * fix: collapse component uses correct ref prop * chore: button label defaultProp * chore: check for undefined label in Button * fix: add default props to ReadoutGroup and ItemDisplay * fix: update spacingScale to use css property * fix: remove commented code, fix tabwrap attrs warning * fix: export GlobalStyles * fix: revert spacingScale change * fix: use different icon for collapse * fix: minor changes to checkbox layout styles * feat: add missing icons * feat: better readability for footer icons * fix: use css variables for spacingscale * feat: improve footer icons * fix: remove unneded style property from links * fix: delete iconbackground * fix: update template to use correct displayname * fix: replace impoperly-formatted icons * feat: fix testing, update deps (#506) * fix: update dependencies, add test util * fix: add comments * chore: update package-lock * chore: uninstall react-test-renderer * test: udpate snapshots * ci: add linting stage * ci: add missing require job * chore: fix all lint warnings * test: update Spinner test * test: update snaps and lint errors * fix: class to className * fix: hack for poor SVG rendering in Chrome * fix: readoutdisplay should now show proper colors * chore: add comment explaining id replacement * fix: remaining attrs refactors * fix: testUtils * fix: checkbox label layout * fix: error in testUtils * test: update snaps * fix: remove duplicate import statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #451