Fixes for tests under windows / jest update to 26.6.3 #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for doing this, @grbd! Your changes look mostly good to me. I just have a few comments, so I'll do a proper review one of the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've recently updated the version of jest and made some changes so that the tests will run under both windows and linux
before windows was throwing some errors due to unexpected results from the path delimiter and because of a slight difference in the file naming with webpack
I've tested under both windows 10 and Manjaro linux, also the yarn.lock file has been updated (I used the changes under the linux environment after a yarn install)