Implicitly convert booleans and numbers to strings when decoding json

grigaman · Sep 20, 2018 · b99a8cf · b99a8cf
1 parent ec63251
commit b99a8cf
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/java/client/src/org/openqa/selenium/json/StringCoercer.java b/java/client/src/org/openqa/selenium/json/StringCoercer.java
@@ -31,9 +31,15 @@ public boolean test(Class<?> type) {
   public BiFunction<JsonInput, PropertySetting, String> apply(Type type) {
     return (jsonInput, setting) -> {
       switch (jsonInput.peek()) {
+        case BOOLEAN:
+          return String.valueOf(jsonInput.nextBoolean());
+
         case NAME:
           return jsonInput.nextName();
 
+        case NUMBER:
+          return String.valueOf(jsonInput.nextNumber());
+
         case STRING:
           return jsonInput.nextString();
 

diff --git a/java/client/test/org/openqa/selenium/json/JsonTest.java b/java/client/test/org/openqa/selenium/json/JsonTest.java
@@ -505,6 +505,24 @@ public void canConvertAnEnumWithALowerCaseValue() {
     assertEquals(Proxy.ProxyType.PAC, type);
   }
 
+  @Test
+  public void canCoerceSimpleValuesToStrings() {
+    Map<String, Object> value = ImmutableMap.of(
+        "boolean", true,
+        "integer", 42,
+        "float", 3.14);
+
+    Json json = new Json();
+    String raw = json.toJson(value);
+    Map<String, String> roundTripped = json.toType(
+        raw,
+        new TypeToken<Map<String, String>>(){}.getType());
+
+    assertEquals("true", roundTripped.get("boolean"));
+    assertEquals("42", roundTripped.get("integer"));
+    assertEquals("3.14", roundTripped.get("float"));
+  }
+
   public static class SimpleBean {
 
     private String value;