Fix 4908 - InfiniteScroll test timing and call to scrollIntoView #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #4908 by adding timers to Jest test, plus mocking
scrollIntoViewfunction which is called in some InfiniteScroll + show scenarios, but is not supported by JSDOM.Where should the reviewer start?
InfiniteScroll-test.js
What testing has been done on this PR?
Jest tests.
Re: reliably reproducing issue - The issue was intermittent because the timer calling
scrollIntoViewcould be longer than the duration of the test. Reducing the timeout duration allowed consistent reproduction, followed by use of Jest timers.How should this be manually tested?
Any background context you want to provide?
There is quite a bit of discussion on the JSDOM project about how to test components relying on the scroll APIs jsdom/jsdom#1695 (comment).
What are the relevant issues?
#4908
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
No.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.