Update dependencies #5817
Closed
Update dependencies #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2021 13:28
|
Why did the Accordion snapshots change? |
Im looking into this Ill let you know |
|
created a new PR this one had to many changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades dependencies to the latest compatible versions.
Did not upgrade to
eslint-config-airbnbThis update I was running into issues related to
It did not agree with how we were writing our functions. We will need to look more into the changes that were made during this major release from 18.2.1 to 19.0.1.
There seems to be a open issue around this already.
airbnb/javascript#2505
There is currently 634 errors with trying to update
Where should the reviewer start?
package.json
What testing has been done on this PR?
Updated tests, ran storybook.
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Closes #2071 in design-system backlog
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
No.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.