Upgrade babel dependencies #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halocline
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Related to #5419 (comment)
Additional context ☝️ in this PR comment.
ericsoderberghp
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates all of the babel dependencies
Where should the reviewer start?
package.json
What testing has been done on this PR?
yarn build-storybook
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
loose: true was already set in tools/grommet-babel-preset-es2015.jsThis was throwing an error because in the storybook babel it was not set to
truewhich was causing mismatch between thebabelconfigfilesalso referring to this PR #5419
if we change the
loose: truethis will increasegrommet.min.jsto about 30% larger.What are the relevant issues?
grommet/hpe-design-system#2094
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
no
Is this change backwards compatible or is it a breaking change?
backwards compatible