Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in CTE association documentation #1544

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

JoeParker
Copy link

This PR addresses a mistake in the code examples for creating Common Table Expression associations.

The example given won't compile; updating the assignment operator to an equality check corrects the snippet and matches the similar example further on in the doc.

Pull Request Checklist

  • CONTRIBUTING: You have read https://github.com/groue/GRDB.swift/blob/master/CONTRIBUTING.md
  • BRANCH: This pull request is submitted against the development branch.
  • DOCUMENTATION: Inline documentation has been updated.
  • DOCUMENTATION: README.md or another dedicated guide has been updated.
  • TESTS: Changes are tested.
  • TESTS: The make smokeTest terminal command runs without failure.

@groue
Copy link
Owner

groue commented May 10, 2024

Thank you @JoeParker,

This sounds like a welcome fix :) I'll review your PR in a few days when I'm back in front of a computer. Please hold on.

@groue groue merged commit 34d87c0 into groue:development Jun 2, 2024
@groue
Copy link
Owner

groue commented Jun 2, 2024

I'm late! Thank you for your contribution, @JoeParker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants