Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Use node.js v16.8.0 for CI #2292

Merged
merged 2 commits into from Sep 13, 2021
Merged

Use node.js v16.8.0 for CI #2292

merged 2 commits into from Sep 13, 2021

Conversation

evantahler
Copy link
Member

@evantahler evantahler commented Sep 13, 2021

The latest version of Node.js has a bug when running jest. For now, we'll lock CI to use v16.8.0 rather than the latest, v16.9.0.

Re: nodejs/node#40030

Prevents cool looking bugs like:

#
# Fatal error in , line 0
# Check failed: !holder_map.has_named_interceptor().
#
#
#
#FailureMessage Object: 0x7ffef0ac0510
 1: 0xb691f1  [/usr/local/bin/node]
 2: 0x1bf3094 V8_Fatal(char const*, ...) [/usr/local/bin/node]
 3: 0x10ac4a1 v8::internal::ConcurrentLookupIterator::TryGetPropertyCell(v8::internal::Isolate*, v8::internal::LocalIsolate*, v8::internal::Handle<v8::internal::JSGlobalObject>, v8::internal::Handle<v8::internal::Name>) [/usr/local/bin/node]
 4: 0x1c5aa55  [/usr/local/bin/node]
 5: 0x1c5b9eb v8::internal::compiler::JSGlobalObjectRef::GetPropertyCell(v8::internal::compiler::NameRef const&, v8::internal::compiler::SerializationPolicy) const [/usr/local/bin/node]
 6: 0x1e61ba3 v8::internal::compiler::JSNativeContextSpecialization::ReduceNamedAccess(v8::internal::compiler::Node*, v8::internal::compiler::Node*, v8::internal::compiler::NamedAccessFeedback const&, v8::internal::compiler::AccessMode, v8::internal::compiler::Node*) [/usr/local/bin/node]
 7: 0x1e623c4 v8::internal::compiler::JSNativeContextSpecialization::ReducePropertyAccess(v8::internal::compiler::Node*, v8::internal::compiler::Node*, v8::base::Optional<v8::internal::compiler::NameRef>, v8::internal::compiler::Node*, v8::internal::compiler::FeedbackSource const&, v8::internal::compiler::AccessMode) [/usr/local/bin/node]
 8: 0x1e62f0c v8::internal::compiler::JSNativeContextSpecialization::ReduceJSLoadProperty(v8::internal::compiler::Node*) [/usr/local/bin/node]
 9: 0x1df5e0a v8::internal::compiler::Reducer::Reduce(v8::internal::compiler::Node*, v8::internal::compiler::ObserveNodeManager*) [/usr/local/bin/node]
10: 0x1c92604  [/usr/local/bin/node]
11: 0x1df60be v8::internal::compiler::GraphReducer::Reduce(v8::internal::compiler::Node*) [/usr/local/bin/node]
12: 0x1df7895 v8::internal::compiler::GraphReducer::ReduceTop() [/usr/local/bin/node]
13: 0x1df7c48 v8::internal::compiler::GraphReducer::ReduceNode(v8::internal::compiler::Node*) [/usr/local/bin/node]
14: 0x1ca03fd v8::internal::compiler::InliningPhase::Run(v8::internal::compiler::PipelineData*, v8::internal::Zone*) [/usr/local/bin/node]
15: 0x1ca1291 v8::internal::compiler::PipelineImpl::CreateGraph() [/usr/local/bin/node]
16: 0x1ca1668 v8::internal::compiler::PipelineCompilationJob::PrepareJobImpl(v8::internal::Isolate*) [/usr/local/bin/node]
17: 0xd94f5d v8::internal::OptimizedCompilationJob::PrepareJob(v8::internal::Isolate*) [/usr/local/bin/node]
18: 0xd96358  [/usr/local/bin/node]
19: 0xd97e70 v8::internal::Compiler::CompileOptimized(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSFunction>, v8::internal::ConcurrencyMode, v8::internal::CodeKind) [/usr/local/bin/node]
20: 0x11f4463 v8::internal::Runtime_CompileOptimized_Concurrent(int, unsigned long*, v8::internal::Isolate*) [/usr/local/bin/node]
21: 0x15e67f9  [/usr/local/bin/node]

@evantahler evantahler added the internal chores and housekeeping label Sep 13, 2021
@evantahler evantahler enabled auto-merge (squash) September 13, 2021 21:17
@evantahler evantahler merged commit 04159c9 into main Sep 13, 2021
@evantahler evantahler deleted the lock-ci-node-version branch September 13, 2021 21:30
pedroslopez pushed a commit that referenced this pull request Sep 15, 2021
* Use node.js v16.8.0 for CI

* Share docker image
pedroslopez added a commit that referenced this pull request Sep 15, 2021
…backports #2298) (#2300)

* fix: dont throw on `profile:destroy` if it has already been deleted
backports #2298

* try test fix

* Use node.js v16.8.0 for CI (#2292)

* Use node.js v16.8.0 for CI

* Share docker image

Co-authored-by: Evan Tahler <evan.tahler@grouparoo.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
internal chores and housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant