This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
limit node versions to under 17 #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teallarson
changed the title
pedroslopez
approved these changes
Oct 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
There is at least one known issue with our setup being compatible with Node17 (related Github issue pertaining to webpack's hashing function). Limiting our Node version to <17.0.0 until our setup is compatible.
Related issues
Does this PR fix a Github Issue?
No.
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review