Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Lock @types/node to v16.x (also fixes mongo) #2758

Merged
merged 1 commit into from Jan 5, 2022

Conversation

evantahler
Copy link
Member

@evantahler evantahler commented Jan 5, 2022

Locked the version of @types/node that we use to the v16 version (because that's the version of node we use). Mongo introduced an incompatibility (mongodb/node-mongodb-native#3088) with v17 of @types/node. They are fixing it soon, but regardless, we should have locked the @types package to the latest major version of node Grouparoo supports.

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@evantahler evantahler added bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 5, 2022
@evantahler evantahler marked this pull request as ready for review January 5, 2022 18:50
Copy link
Contributor

@pauloouriques pauloouriques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked like a charm here.

@@ -42,7 +42,7 @@
},
"devDependencies": {
"@types/fs-extra": "*",
"@types/node": "*",
"@types/node": "16.*.*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@evantahler evantahler merged commit cbd9482 into main Jan 5, 2022
@evantahler evantahler deleted the 180814114-lock-types/node-version branch January 5, 2022 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants