This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
update to commander@9.0.0
, remove negated cli param defaults
#2932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Supersedes #2911
In the latest version of commander, the behavior of default values for boolean options has changed (see tj/commander.js#1652). This affects our use of negated options with a default value.
With a param
no-exports
withdefault: false
...Previously (8.3.0):
Now (9.0.0):
This meant that
roo run
by default was no longer exporting records after the commander upgrade. Removing the default value from these negated boolean options returns the expected behavior.Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review