Switch from lerna to pnpm #888

evantahler · 2020-10-23T17:44:35Z

pnpm is faster, shares dependencies and can still support monorepos.

Tasks:

Notes:

We can still use Lerna to publish and update versons... just not for managing dependencies.

Closes T-655

evantahler · 2020-10-23T19:40:15Z

Currently blocked when running tests against a next.js error:

    ReferenceError: URL is not defined

      at Object.<anonymous> (../../node_modules/.pnpm/next@9.5.6-canary.13_8276e7ef4e4bcb622af0fe7b5225f62d/node_modules/next/next-server/lib/router/utils/parse-relative-url.ts:8:1)
      at Object.<anonymous> (../../node_modules/.pnpm/next@9.5.6-canary.13_8276e7ef4e4bcb622af0fe7b5225f62d/node_modules/next/next-server/lib/router/utils/prepare-destination.ts:4:1)
      at Object.<anonymous> (../../node_modules/.pnpm/next@9.5.6-canary.13_8276e7ef4e4bcb622af0fe7b5225f62d/node_modules/next/next-server/server/next-server.ts:65:1)
      at Object.<anonymous> (../../node_modules/.pnpm/next@9.5.6-canary.13_8276e7ef4e4bcb622af0fe7b5225f62d/node_modules/next/server/next.ts:3:1)
      at Object.<anonymous> (../../node_modules/.pnpm/ah-next-plugin@0.3.0_5139af8b50ead0a453273331284dbaed/node_modules/ah-next-plugin/dist/initializers/next.js:8:32)

evantahler · 2020-10-27T18:34:54Z

The Next error was resolved by actionhero/ah-next-plugin#115

height · 2020-10-27T18:35:11Z

This pull request has been linked to and will mark 1 task as "Delivered" when merged:

~~T-655 Investigate moving from lerna + npm to pnpm~~ (unlink task)

💡Tip: You can link multiple Height tasks to a pull request.

evantahler · 2020-10-27T20:29:44Z

@bleonard can you give this branch a whirl to make sure everything works for you? start with npm run nuke and then try pnpm install. It should install all the deps and build all the packages... but faster! Also, check out both npm run start and npm run dev... which should preform about the same as they do on master.

evantahler · 2020-10-29T23:54:44Z

If this PR is merged - Update https://www.grouparoo.com/docs/development

bleonard · 2020-10-29T23:58:59Z

Started with fresh directory
> npm i -g pnpm
> pnpm install

apps/staging-public> npm run dev seems to work.

apps/staging-public> npm start has this error:

➜  staging-public git:(pnpm) npm start

> @grouparoo/app-staging-public@0.1.23 start /Users/brian/grouparoo/test/grouparoo/apps/staging-public
> cd node_modules/@grouparoo/core && GROUPAROO_MONOREPO_APP=staging-public ./api/bin/start

modified your runtime environment with /Users/brian/grouparoo/test/grouparoo/apps/staging-public/.env

!!! plugin @grouparoo/files-s3 requires environment variable S3_ACCESS_KEY to be set !!!


!!! plugin @grouparoo/files-s3 requires environment variable S3_SECRET_ACCESS_KEY to be set !!!


!!! plugin @grouparoo/files-s3 requires environment variable S3_REGION to be set !!!


!!! plugin @grouparoo/files-s3 requires environment variable S3_BUCKET to be set !!!


!!! plugin @grouparoo/newrelic requires environment variable NEW_RELIC_LICENSE_KEY to be set !!!


!!! plugin @grouparoo/newrelic requires environment variable NEW_RELIC_APP_NAME to be set !!!

not injecting newrelic because NEW_RELIC_LICENSE_KEY is not set
2020-10-29T23:55:41.902Z - notice: Starting Grouparoo 0.1.23 on node.js v12.16.3 
2020-10-29T23:55:42.395Z - info: UNHANDLED REJECTION: Error: Cannot find module 'validator/lib/isURL'
Require stack:
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/modules/ops/profileProperty.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/ProfileProperty.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/ProfilePropertyRule.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/GroupRule.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/Group.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/GroupMember.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/Profile.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/Run.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/Schedule.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/Source.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/models/App.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/modules/plugin.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/index.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/initializers/events.js
- /Users/brian/grouparoo/test/grouparoo/node_modules/.pnpm/actionhero@24.0.1/node_modules/actionhero/dist/classes/process.js
- /Users/brian/grouparoo/test/grouparoo/node_modules/.pnpm/actionhero@24.0.1/node_modules/actionhero/dist/index.js
- /Users/brian/grouparoo/test/grouparoo/core/api/dist/grouparoo.js

bleonard · 2020-10-30T01:24:32Z

Stats from my computer.
master: npm install 1028.81s user 236.01s system 138% cpu 15:16.08 total
pnpm: pnpm install 537.00s user 53.32s system 166% cpu 5:54.92 total

3x faster 🎉

bleonard · 2020-10-30T01:25:57Z

npm start is looking good now.

bleonard · 2020-10-30T15:54:50Z

pnpm-workspace.yaml

+  - "clients/**"
+  - "plugins/**"
+  - "apps/**"
+  - "!apps/local-public"


why not this one?

We ignore it in Lerna-land as well https://github.com/grouparoo/grouparoo/blob/master/lerna.json#L11-L13

Just so we don't need to wait for 2 apps to build when installing

evantahler added the dependencies Pull requests that update a dependency file label Oct 23, 2020

evantahler added the BLOCKED do not merge label Oct 23, 2020

evantahler mentioned this pull request Oct 27, 2020

Use Nextjs v10 #912

Merged

evantahler force-pushed the pnpm branch 2 times, most recently from 4a2bdbd to d134a95 Compare October 27, 2020 17:55

evantahler marked this pull request as ready for review October 27, 2020 18:55

evantahler requested a review from bleonard October 27, 2020 20:28

evantahler removed the BLOCKED do not merge label Oct 29, 2020

bleonard reviewed Oct 30, 2020

View reviewed changes

evantahler and others added 12 commits November 3, 2020 11:04

Switch from lerna to pnpm

540d762

build for ci

afdf588

sudo install pnpm

0c5a634

tools need pnpm

32c5ee2

cli test wants pnpm too

8644f88

build ci yml

aaba6e8

pnpm installs!

3bf0818

disable next for api tests

e60181f

revert test override

d50c2e8

lint command include -r

2379b1b

continue to use lerna for publishing and versioning

587d551

add validator package to core

ee5668f

evantahler force-pushed the pnpm branch from 1073909 to ee5668f Compare November 3, 2020 19:04

evantahler added 4 commits November 3, 2020 11:33

update versions and heroku commands

93d0f2d

only run preinstall pnpm check when NODE_ENV=development

626e8a0

ignore lockfiles in spell-checker

4055c2d

update test commands

f90f12d

evantahler merged commit 7afc2bd into master Nov 3, 2020

evantahler deleted the pnpm branch November 3, 2020 20:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch from lerna to pnpm #888

Switch from lerna to pnpm #888

evantahler commented Oct 23, 2020 •

edited

evantahler commented Oct 23, 2020

evantahler commented Oct 27, 2020

height bot commented Oct 27, 2020 •

edited

evantahler commented Oct 27, 2020

evantahler commented Oct 29, 2020

bleonard commented Oct 29, 2020 •

edited

bleonard commented Oct 30, 2020

bleonard commented Oct 30, 2020

bleonard Oct 30, 2020

evantahler Oct 30, 2020

Switch from lerna to pnpm #888

Switch from lerna to pnpm #888

Conversation

evantahler commented Oct 23, 2020 • edited

evantahler commented Oct 23, 2020

evantahler commented Oct 27, 2020

height bot commented Oct 27, 2020 • edited

evantahler commented Oct 27, 2020

evantahler commented Oct 29, 2020

bleonard commented Oct 29, 2020 • edited

bleonard commented Oct 30, 2020

bleonard commented Oct 30, 2020

bleonard Oct 30, 2020

Choose a reason for hiding this comment

evantahler Oct 30, 2020

Choose a reason for hiding this comment

evantahler commented Oct 23, 2020 •

edited

height bot commented Oct 27, 2020 •

edited

bleonard commented Oct 29, 2020 •

edited