Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

close.io docs added with navigation and images #964

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Adorism
Copy link
Contributor

@Adorism Adorism commented Mar 1, 2022

Change description

New documentation page added for Close.io. Includes accompanying images and navigation.

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@Adorism Adorism added the documentation Improvements or additions to documentation label Mar 1, 2022
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I do wonder if we want to shift toward calling them Close/Close CRM as that's what they call themselves it looks like... but our package is called @grouparoo/closeio so I'm torn there.

pages/docs/integrations/grouparoo-closeio.mdx Outdated Show resolved Hide resolved
Co-authored-by: Teal Larson <teal.larson@grouparoo.com>
@Adorism
Copy link
Contributor Author

Adorism commented Mar 2, 2022

I'll look into the naming we should use for them. And I think I should wait for the sync methods PR to merge /make a small edit related to that as well.

@Adorism Adorism closed this Mar 2, 2022
@Adorism Adorism reopened this Mar 3, 2022
@Adorism Adorism marked this pull request as draft March 3, 2022 15:45
@Adorism Adorism marked this pull request as ready for review March 7, 2022 17:45
@evantahler evantahler removed their request for review March 10, 2022 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants