Fix operator precedence in advanced attribute targeting #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-2516-bttf has been deployed. Preview environment endpoints are available at: |
|
Deploy preview for docs ready! ✅ Preview Built with commit efea191. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Currently due to the use of
in, a single special operator (or/nor/and/not) in a nestedConditionInterfacewill ignore all other keys at that level. From the mongo docs it looks like we should be allowing multiple keys on a single level, even with operators like$or.Testing
$or(or other special operator) and at least one other operator, both at the top level.$orcondition passes, but the other condition failsScreenshots
Experiment setup:
Importing from npm package (no fix)
Importing from local package (with fix)