Moved imports to v2; Moved to Go 1.14.2 #290
Conversation
go.mod
Outdated
| @@ -11,4 +11,4 @@ require ( | |||
| google.golang.org/grpc v1.19.0 | |||
| ) | |||
|
|
|||
| go 1.13 | |||
| go 1.14 | |||
There was a problem hiding this comment.
Nit: can we move this above the require statement?
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "github.com/stretchr/testify/suite" | ||
| "google.golang.org/grpc" | ||
| "google.golang.org/grpc/codes" | ||
|
|
||
| pb_testproto "github.com/grpc-ecosystem/go-grpc-middleware/grpctesting/testproto" | ||
| pb_testproto "github.com/grpc-ecosystem/go-grpc-middleware/v2/grpctesting/testproto" |
There was a problem hiding this comment.
What import grouping do we want to use? This is a little inconsistent. I usually do 3 import groups. Maybe now is a good time to change?
There was a problem hiding this comment.
so I use goimports which does 2 groups. What do you prefer? I am fine with whatever as long as there is popular auto formatting tool for this (:
| "github.com/grpc-ecosystem/go-grpc-middleware/v2/grpctesting" | ||
| "google.golang.org/grpc/status" | ||
|
|
||
| pb_testproto "github.com/grpc-ecosystem/go-grpc-middleware/grpctesting/testproto" | ||
| pb_testproto "github.com/grpc-ecosystem/go-grpc-middleware/v2/grpctesting/testproto" |
There was a problem hiding this comment.
yea not formatted well
There was a problem hiding this comment.
will fix in later PR
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Codecov Report
@@ Coverage Diff @@
## v2 #290 +/- ##
==========================================
- Coverage 84.01% 83.58% -0.43%
==========================================
Files 30 30
Lines 932 932
==========================================
- Hits 783 779 -4
- Misses 110 114 +4
Partials 39 39
Continue to review full report at Codecov.
|
|
Ok I moved to Go v2 , but let's fix formatting later, go list does not work without tag now |
Following https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher we need this. It might be still non-buildable.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com